Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: Source/core/html/HTMLImageFallbackHelper.h

Issue 481753002: Use Shadow DOM to display fallback content for images (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLImageFallbackHelper.h
diff --git a/Source/core/html/HTMLImageFallbackHelper.h b/Source/core/html/HTMLImageFallbackHelper.h
new file mode 100644
index 0000000000000000000000000000000000000000..2e8ef39e792de29e8e3b1f681638d159ae343835
--- /dev/null
+++ b/Source/core/html/HTMLImageFallbackHelper.h
@@ -0,0 +1,133 @@
+/*
+ * Copyright (C) 2014 Robert Hogan <robhogan@chromium.org>.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
+ *
+ * You should have received a copy of the GNU Library General Public License
+ * along with this library; see the file COPYING.LIB. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+ * Boston, MA 02110-1301, USA.
+ *
+ */
+
+#ifndef HTMLImageFallbackHelper_h
+#define HTMLImageFallbackHelper_h
+
+#include "core/HTMLNames.h"
+#include "core/InputTypeNames.h"
+#include "core/dom/ElementRareData.h"
+#include "core/dom/Text.h"
+#include "core/dom/shadow/ShadowRoot.h"
+#include "core/fetch/ImageResource.h"
+#include "core/html/FormDataList.h"
+#include "core/html/HTMLDivElement.h"
+#include "core/html/HTMLImageElement.h"
+#include "core/html/HTMLImageLoader.h"
+#include "core/html/HTMLInputElement.h"
+#include "core/html/HTMLStyleElement.h"
+#include "wtf/PassOwnPtr.h"
+#include "wtf/text/StringBuilder.h"
+
+namespace blink {
+
+using namespace HTMLNames;
+
+static bool noImageSourceSpecified(Element* element)
esprehn 2014/09/05 00:47:51 reference
rhogan 2014/09/08 19:52:41 Done
+{
+ bool noSrcSpecified = !element->hasAttribute(srcAttr) || element->getAttribute(srcAttr).isNull() || element->getAttribute(srcAttr).isEmpty();
+ bool noSrcsetSpecified = !element->hasAttribute(srcsetAttr) || element->getAttribute(srcsetAttr).isNull() || element->getAttribute(srcsetAttr).isEmpty();
+ return noSrcSpecified && noSrcsetSpecified;
+}
+
+static String altTextForElement(Element* element)
esprehn 2014/09/05 00:47:51 reference
rhogan 2014/09/08 19:52:42 Done
+{
+ ASSERT(isHTMLImageElement(element) || isHTMLInputElement(element));
+ if (isHTMLImageElement(element))
+ return toHTMLImageElement(element)->altText();
+ return toHTMLInputElement(element)->altText();
esprehn 2014/09/05 00:47:51 Just add a virtual method to HTMLElement.h and rem
rhogan 2014/09/08 19:52:41 Done
+}
+
+static Text* createAltTextShadowTree(Element* element)
esprehn 2014/09/05 00:47:51 void.
+{
+ ShadowRoot* root = element->userAgentShadowRoot();
esprehn 2014/09/05 00:47:51 Reference, and use ensureUserAgentShadowRoot()
rhogan 2014/09/08 19:52:41 Done
+ RefPtr<HTMLStyleElement> style = HTMLStyleElement::create(element->document(), false);
+ style->setTextContent("#alttext-container { overflow: hidden; border: 1px solid silver; padding: 1px; display: inline-block; box-sizing: border-box; }"
+ "#alttext { overflow: hidden; display: block; }"
+ "#alttext-image { margin: 0px; }");
+ root->appendChild(style.release());
+
+ RefPtr<HTMLDivElement> container = HTMLDivElement::create(element->document());
+ container->setAttribute(idAttr, AtomicString("alttext-container", AtomicString::ConstructFromLiteral));
+ root->appendChild(container);
+
+ RefPtr<HTMLImageElement> brokenImage = HTMLImageElement::create(element->document());
+ brokenImage->setIsFallbackImage();
+ container->appendChild(brokenImage);
+ brokenImage->setAttribute(idAttr, AtomicString("alttext-image", AtomicString::ConstructFromLiteral));
+ brokenImage->setAttribute(widthAttr, AtomicString("16", AtomicString::ConstructFromLiteral));
+ brokenImage->setAttribute(heightAttr, AtomicString("16", AtomicString::ConstructFromLiteral));
+ brokenImage->setAttribute(alignAttr, AtomicString("left", AtomicString::ConstructFromLiteral));
+ brokenImage->setAttribute(srcAttr, AtomicString("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAABO0lEQVR4XpWRTytEYRTG3/tHLGQr"
+ "NfEBpKQkmc8gG0ulxpRsfQ0TTXbI3kZ2ys4tsyBZjN1N8idlYUYaxJzzOKf7ztG1MfN0ens69/x6"
+ "n/eeYPuo7npS9bCOriXDMQOCTVbO3X+6Wp9mICZWAHqquE1qAA8EQRiFcmYMsQKsAHM2DeKV4qj4"
+ "8ZHB++bHwcXTQ+Mz6u/rABwSIQO0wKW5wuLU8E5yWzlJS7OFvaUJMGelAFkkYici1NIXB4DQbH1J"
+ "Y2ggVoD4N1Kb2AAA149vUmLLxbHaTaNynIJggAz7G7jTyjB5wOv79/LupT47Cu0rcT6S/ai755YU"
+ "iMM4cgw4/I3ERAaI3y/PiFnYPHOBtfORLKX38AaBERaJbHFeAOY3Eu8ZOYByi7Pl+hzWN+nwWjVB"
+ "15LhYHXr1PWiH0AYTw4BBjO9AAAAAElFTkSuQmCC", AtomicString::ConstructFromLiteral));
+
+ RefPtr<HTMLDivElement> altText = HTMLDivElement::create(element->document());
+ altText->setAttribute(idAttr, AtomicString("alttext", AtomicString::ConstructFromLiteral));
+ container->appendChild(altText);
+
+ RefPtr<Text> text = Text::create(element->document(), altTextForElement(element));
+ altText->appendChild(text);
+ return text.get();
+}
+
+static PassRefPtr<RenderStyle> customStyleForAltText(Element* element, PassRefPtr<RenderStyle> newStyle)
esprehn 2014/09/05 00:47:51 reference
rhogan 2014/09/08 19:52:42 Done
+{
+ Element* placeHolder = element->userAgentShadowRoot()->getElementById("alttext-container");
esprehn 2014/09/05 00:47:51 ensureUserAgentShadowRoot(), I would also save it
rhogan 2014/09/08 19:52:42 Done
+ Element* brokenImage = element->userAgentShadowRoot()->getElementById("alttext-image");
+ if (element->document().inQuirksMode()) {
+ // Mimic the behaviour of the image host by setting symmetric dimensions if only one dimension is specified.
+ if (newStyle->width().isSpecifiedOrIntrinsic() && newStyle->height().isAuto())
+ newStyle->setHeight(newStyle->width());
+ else if (newStyle->height().isSpecifiedOrIntrinsic() && newStyle->width().isAuto())
+ newStyle->setWidth(newStyle->height());
+ if (newStyle->width().isSpecifiedOrIntrinsic() && newStyle->height().isSpecifiedOrIntrinsic() && !element->shadowRoot() && element->userAgentShadowRoot()) {
+ placeHolder->setInlineStyleProperty(CSSPropertyVerticalAlign, CSSValueBaseline);
+ }
+ }
+
+ // If the image has specified dimensions allow the alt-text container expand to fill them.
+ if (newStyle->width().isSpecifiedOrIntrinsic() && newStyle->height().isSpecifiedOrIntrinsic() && !element->shadowRoot() && element->userAgentShadowRoot()) {
esprehn 2014/09/05 00:47:51 Why do you need to keep checking for userAgentShad
rhogan 2014/09/08 19:52:41 I don't. This was cruft.
rhogan 2014/09/08 19:52:41 I don't. This was cruft.
+ placeHolder->setInlineStyleProperty(CSSPropertyWidth, 100, CSSPrimitiveValue::CSS_PERCENTAGE);
+ placeHolder->setInlineStyleProperty(CSSPropertyHeight, 100, CSSPrimitiveValue::CSS_PERCENTAGE);
+ }
+
+ // Make sure the broken image icon appears on the appropriate side of the image for the element's writing direction.
+ if (!element->shadowRoot() && element->userAgentShadowRoot())
esprehn 2014/09/05 00:47:51 This doesn't make sense, what are you trying to ch
rhogan 2014/09/08 19:52:41 See above. It was unnecessary cruft.
+ brokenImage->setAttribute(alignAttr, AtomicString(newStyle->direction() == LTR ? "left" : "right"));
+
+ // This is an <img> with no attributes, so don't display anything.
+ if (noImageSourceSpecified(element) && !newStyle->width().isSpecifiedOrIntrinsic() && !newStyle->height().isSpecifiedOrIntrinsic() && altTextForElement(element).isEmpty())
+ newStyle->setDisplay(NONE);
+
+ // This preserves legacy behaviour originally defined when alt-text was managed by RenderImage.
+ if (noImageSourceSpecified(element) && altTextForElement(element).isEmpty() && !element->shadowRoot() && element->userAgentShadowRoot())
+ brokenImage->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
+
+ return newStyle;
+}
+
+}
+
+#endif

Powered by Google App Engine
This is Rietveld 408576698