Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: Source/core/html/HTMLImageLoader.cpp

Issue 481753002: Use Shadow DOM to display fallback content for images (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
11 * This library is distributed in the hope that it will be useful, 11 * This library is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of 12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
14 * Library General Public License for more details. 14 * Library General Public License for more details.
15 * 15 *
16 * You should have received a copy of the GNU Library General Public License 16 * You should have received a copy of the GNU Library General Public License
17 * along with this library; see the file COPYING.LIB. If not, write to 17 * along with this library; see the file COPYING.LIB. If not, write to
18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 18 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
19 * Boston, MA 02110-1301, USA. 19 * Boston, MA 02110-1301, USA.
20 */ 20 */
21 21
22 #include "config.h" 22 #include "config.h"
23 #include "core/html/HTMLImageLoader.h" 23 #include "core/html/HTMLImageLoader.h"
24 24
25 #include "core/HTMLNames.h" 25 #include "core/HTMLNames.h"
26 #include "core/dom/Element.h" 26 #include "core/dom/Element.h"
27 #include "core/events/Event.h" 27 #include "core/events/Event.h"
28 #include "core/fetch/ImageResource.h" 28 #include "core/fetch/ImageResource.h"
29 #include "core/html/HTMLImageElement.h" 29 #include "core/html/HTMLImageElement.h"
30 #include "core/html/HTMLInputElement.h"
30 #include "core/html/HTMLObjectElement.h" 31 #include "core/html/HTMLObjectElement.h"
31 #include "core/html/parser/HTMLParserIdioms.h" 32 #include "core/html/parser/HTMLParserIdioms.h"
32 #include "platform/Logging.h" 33 #include "platform/Logging.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 HTMLImageLoader::HTMLImageLoader(Element* node) 37 HTMLImageLoader::HTMLImageLoader(Element* node)
37 : ImageLoader(node) 38 : ImageLoader(node)
38 { 39 {
39 } 40 }
(...skipping 14 matching lines...) Expand all
54 if (isHTMLObjectElement(*element()) && !errorOccurred) 55 if (isHTMLObjectElement(*element()) && !errorOccurred)
55 errorOccurred = (image()->response().httpStatusCode() >= 400); // An <ob ject> considers a 404 to be an error and should fire onerror. 56 errorOccurred = (image()->response().httpStatusCode() >= 400); // An <ob ject> considers a 404 to be an error and should fire onerror.
56 element()->dispatchEvent(Event::create(errorOccurred ? EventTypeNames::error : EventTypeNames::load)); 57 element()->dispatchEvent(Event::create(errorOccurred ? EventTypeNames::error : EventTypeNames::load));
57 } 58 }
58 59
59 String HTMLImageLoader::sourceURI(const AtomicString& attr) const 60 String HTMLImageLoader::sourceURI(const AtomicString& attr) const
60 { 61 {
61 return stripLeadingAndTrailingHTMLSpaces(attr); 62 return stripLeadingAndTrailingHTMLSpaces(attr);
62 } 63 }
63 64
65 void HTMLImageLoader::noImageResourceToLoad()
66 {
67 RefPtrWillBeRawPtr<Element> element = this->element();
68 // FIXME: Use fallback content even when there is no alt-text. The only bloc ker is the large amount of rebaselining it requires.
69 if (isHTMLImageElement(*element) && !toHTMLImageElement(element)->altText(). isEmpty())
70 toHTMLImageElement(element)->ensureFallbackContent();
71 if (isHTMLInputElement(*element) && !toHTMLInputElement(element)->altText(). isEmpty())
72 toHTMLInputElement(element)->ensureFallbackContent();
esprehn 2014/09/05 00:47:51 Lets just add a virtual method.
rhogan 2014/09/08 19:52:42 Done.
73 }
74
64 void HTMLImageLoader::notifyFinished(Resource*) 75 void HTMLImageLoader::notifyFinished(Resource*)
65 { 76 {
66 ImageResource* cachedImage = image(); 77 ImageResource* cachedImage = image();
67 78
68 RefPtrWillBeRawPtr<Element> element = this->element(); 79 RefPtrWillBeRawPtr<Element> element = this->element();
69 ImageLoader::notifyFinished(cachedImage); 80 ImageLoader::notifyFinished(cachedImage);
70 81
71 bool loadError = cachedImage->errorOccurred() || cachedImage->response().htt pStatusCode() >= 400; 82 bool loadError = cachedImage->errorOccurred() || cachedImage->response().htt pStatusCode() >= 400;
83 if (isHTMLImageElement(*element)) {
84 if (loadError)
85 toHTMLImageElement(element)->ensureFallbackContent();
86 else
87 toHTMLImageElement(element)->ensurePrimaryContent();
88 }
89
90 if (isHTMLInputElement(*element)) {
91 if (loadError)
92 toHTMLInputElement(element)->ensureFallbackContent();
esprehn 2014/09/05 00:47:51 virtual.
rhogan 2014/09/08 19:52:42 Done.
93 else
94 toHTMLInputElement(element)->ensurePrimaryContent();
95 }
72 96
73 if (loadError && isHTMLObjectElement(*element)) 97 if (loadError && isHTMLObjectElement(*element))
74 toHTMLObjectElement(element)->renderFallbackContent(); 98 toHTMLObjectElement(element)->renderFallbackContent();
75 } 99 }
76 100
77 } 101 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698