Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 481743003: Always read .skp files and other serialized pictures into SkRecord. (Closed)

Created:
6 years, 4 months ago by mtklein_C
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Always read .skp files and other serialized pictures into SkRecord. This should switch all our internal tools that aren't clever about it over to SkRecord pictures. (The clever tools know what they're doing.) Also, deletes the old SkPicture::clone() path. return this or die. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7b705bb17e09508e3761b54f59833b1ceb4ce9a6 Committed: https://skia.googlesource.com/skia/+/1b523babbe50df1894b10eb5a54fc9d0cf23723d

Patch Set 1 #

Patch Set 2 : Try to placate 10.6 compiler. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/core/SkPicture.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mtklein
6 years, 4 months ago (2014-08-20 21:08:41 UTC) #1
mtklein
+reed for include/
6 years, 4 months ago (2014-08-20 21:09:13 UTC) #2
reed1
lgtm
6 years, 4 months ago (2014-08-20 21:10:36 UTC) #3
robertphillips
lgtm
6 years, 4 months ago (2014-08-20 21:11:22 UTC) #4
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-20 21:16:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/481743003/1
6 years, 4 months ago (2014-08-20 21:16:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 7b705bb17e09508e3761b54f59833b1ceb4ce9a6
6 years, 4 months ago (2014-08-20 21:23:05 UTC) #7
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-20 22:41:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/481743003/20001
6 years, 4 months ago (2014-08-20 22:42:21 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (20001) as 1b523babbe50df1894b10eb5a54fc9d0cf23723d
6 years, 4 months ago (2014-08-20 22:50:53 UTC) #10
mtklein
6 years, 4 months ago (2014-08-20 23:29:38 UTC) #11
Message was sent while issue was closed.
On 2014/08/20 22:50:53, I haz the power (commit-bot) wrote:
> Committed patchset #2 (20001) as 1b523babbe50df1894b10eb5a54fc9d0cf23723d

Mike and I looked at some profiles and we've pegged the regression down:
  - my earlier testing was whole-page with no BBH and the top-left 256x256 tile
with a tile grid.  Both those look good.
  - nanobench tests a 1000x1000 viewport with no BBH
  - SkPictureData has its own special text-only-Y-only built-in BBH, which makes
this sort of thing faster on text heavy pages.

I'm going to hack up and propose some changes to nanobench's SKP rendering
tomorrow to see if I can make things a fair comparison.  I think we should be
measuring tiles with a BBH on the bots, and am open to ideas about what other
modes to support in the tool.

Will give this another try after that's all done.

Powered by Google App Engine
This is Rietveld 408576698