fpdfsdk/src/fsdk_baseform.cpp - Issue 481733002: Fix a double-free issue in CFX_PathData::~CFX_PathData

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_baseform.cpp

Issue 481733002: Fix a double-free issue in CFX_PathData::~CFX_PathData (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fsdk_baseform.cpp

diff --git a/fpdfsdk/src/fsdk_baseform.cpp b/fpdfsdk/src/fsdk_baseform.cpp

index ae3b6364d31d31804e59edd357d4171cfa8f9ac0..aa87dd56bb1951227ddc8048ba56005eec109edf 100644

--- a/fpdfsdk/src/fsdk_baseform.cpp

+++ b/fpdfsdk/src/fsdk_baseform.cpp

@@ -2284,12 +2284,6 @@ FX_BOOL CPDFSDK_InterForm::SubmitFields(const CFX_WideString& csDestination, con

pEnv->JS_docSubmitForm(pBuffer, nBufSize, (FX_LPCWSTR)csDestination);

- if (bUrlEncoded && pBuffer)

- {

- FX_Free(pBuffer);

- pBuffer = NULL;

- }

return TRUE;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »