Omnibox: Prevent Asynchronous Suggestions from Changing Default Match

components/omnibox/base_search_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/omnibox/base_search_provider.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/metrics/proto/omnibox_event.pb.h"
@@ skipping 87 matching lines @@
   return match.GetAdditionalInfo(kShouldPrefetchKey) == kTrue;
 }
 
 // static
 AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(
     const base::string16& suggestion,
     AutocompleteMatchType::Type type,
     bool from_keyword_provider,
     const TemplateURL* template_url,
     const SearchTermsData& search_terms_data) {
-  // This call uses a number of default values.  For instance, it assumes that
-  // if this match is from a keyword provider than the user is in keyword mode.
+  // These calls use a number of default values.  For instance, they assume
+  // that if this match is from a keyword provider, then the user is in keyword
+  // mode.  They also assume the caller knows what it's doing and we set
+  // this match to look as if it was received/created synchronously.
+  SearchSuggestionParser::SuggestResult suggest_result(
+      suggestion, type, suggestion, base::string16(), base::string16(),
+      base::string16(), base::string16(), std::string(), std::string(),
+      from_keyword_provider, 0, false, false, base::string16());
+  suggest_result.set_received_after_last_keystroke(false);
   return CreateSearchSuggestion(
-      NULL, AutocompleteInput(), from_keyword_provider,
-      SearchSuggestionParser::SuggestResult(
-          suggestion, type, suggestion, base::string16(), base::string16(),
-          base::string16(), base::string16(), std::string(), std::string(),
-          from_keyword_provider, 0, false, false, base::string16()),
+      NULL, AutocompleteInput(), from_keyword_provider, suggest_result,
       template_url, search_terms_data, 0, false);
 }
 
 void BaseSearchProvider::DeleteMatch(const AutocompleteMatch& match) {
   DCHECK(match.deletable);
   if (!match.GetAdditionalInfo(BaseSearchProvider::kDeletionUrlKey).empty()) {
     deletion_handlers_.push_back(new SuggestionDeletionHandler(
         match.GetAdditionalInfo(BaseSearchProvider::kDeletionUrlKey),
         client_->RequestContext(),
         base::Bind(&BaseSearchProvider::OnDeletionComplete,
@@ skipping 100 matching lines @@
       (base::CollapseWhitespace(input.text(), false) ==
        suggestion.match_contents());
 
   // When the user forced a query, we need to make sure all the fill_into_edit
   // values preserve that property.  Otherwise, if the user starts editing a
   // suggestion, non-Search results will suddenly appear.
   if (input.type() == metrics::OmniboxInputType::FORCED_QUERY)
     match.fill_into_edit.assign(base::ASCIIToUTF16("?"));
   if (suggestion.from_keyword_provider())
     match.fill_into_edit.append(match.keyword + base::char16(' '));
+  // We only allow inlinable navsuggestions that were received before the
+  // last keystroke because we don't want asynchronous inline autocompletions.
   if (!input.prevent_inline_autocomplete() &&
+      !suggestion.received_after_last_keystroke() &&
       (!in_keyword_mode || suggestion.from_keyword_provider()) &&
       StartsWith(suggestion.suggestion(), input.text(), false)) {
     match.inline_autocompletion =
         suggestion.suggestion().substr(input.text().length());
     match.allowed_to_be_default_match = true;
   }
   match.fill_into_edit.append(suggestion.suggestion());
 
   const TemplateURLRef& search_url = template_url->url_ref();
   DCHECK(search_url.SupportsReplacement(search_terms_data));
@@ skipping 207 matching lines @@
 }
 
 void BaseSearchProvider::OnDeletionComplete(
     bool success, SuggestionDeletionHandler* handler) {
   RecordDeletionResult(success);
   SuggestionDeletionHandlers::iterator it = std::find(
       deletion_handlers_.begin(), deletion_handlers_.end(), handler);
   DCHECK(it != deletion_handlers_.end());
   deletion_handlers_.erase(it);
 }