content/browser/android/content_startup_flags.cc - Issue 481683003: Support for Adaptive Handle Orientation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_startup_flags.cc

Issue 481683003: Support for Adaptive Handle Orientation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed as per jdduke comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_startup_flags.cc

diff --git a/content/browser/android/content_startup_flags.cc b/content/browser/android/content_startup_flags.cc

index 3690d61cf9a5cdbfa195dcb561a127e3e2588846..72bd69b46040e83005e1a2d65948d5510c53caf5 100644

--- a/content/browser/android/content_startup_flags.cc

+++ b/content/browser/android/content_startup_flags.cc

@@ -65,6 +65,8 @@ void SetContentCommandLineFlags(bool single_process,

// TODO(jdduke): Use the proper SDK version when available, crbug.com/466749.

if (base::android::BuildInfo::GetInstance()->sdk_int() >

base::android::SDK_VERSION_LOLLIPOP_MR1) {

+ parsed_command_line->AppendSwitch(

+ switches::kEnableAdaptiveHandleOrientation);

jdduke (slow) 2015/09/09 22:19:50 Can we just not add the flag here? I'd much prefer

AviD 2015/09/10 06:06:13 Done.

parsed_command_line->AppendSwitch(switches::kEnableLongpressDragSelection);

parsed_command_line->AppendSwitchASCII(

switches::kTouchTextSelectionStrategy, "direction");