extensions/common/csp_validator_unittest.cc - Issue 481643002: Disallow non-subdomain wildcards in the extension's CSP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/csp_validator_unittest.cc

Issue 481643002: Disallow non-subdomain wildcards in the extension's CSP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disallow RCD and non-subdomain wildcards Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/csp_validator_unittest.cc

diff --git a/extensions/common/csp_validator_unittest.cc b/extensions/common/csp_validator_unittest.cc

index 693a79106764e2870c816a588ecc7b92c86563f5..354bbd8531886898169101e75ecb8bf9ce018621 100644

--- a/extensions/common/csp_validator_unittest.cc

+++ b/extensions/common/csp_validator_unittest.cc

@@ -99,11 +99,26 @@ TEST(ExtensionCSPValidator, IsSecure) {

EXPECT_FALSE(ContentSecurityPolicyIsSecure(

"default-src 'self' *:*/path", Manifest::TYPE_EXTENSION));

EXPECT_FALSE(ContentSecurityPolicyIsSecure(

+ "default-src 'self' https://", Manifest::TYPE_EXTENSION));