Mac: Support default browser Handoff in Yosemite.

Mac: Support default browser Handoff in Yosemite.

This allows Chrome to accept a Handoff from any app when Chrome is the default
browser.  This has been manually tested.

Note that getting this to work in Yosemite DP5 requires manual modification of
the Info.plist prior to codesigning, as well as Chrome to be built as a 64-bit
binary. The former is an Apple bug, and the latter won't matter, since we're
phasing Chrome off of 32-bits. See bug for more details.

BUG=381516
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290404

[erikchen, 2014-08-15 22:48:17]

avi: Please review.

[Avi (use Gerrit), 2014-08-15 22:51:00]

LGTM

https://codereview.chromium.org/481563002/diff/20001/chrome/browser/app_contr...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/481563002/diff/20001/chrome/browser/app_contr...
chrome/browser/app_controller_mac.mm:1557: (void (^)(NSArray*
restorableObjects))restorationHandler {
Do you need the name "restorableObjects" here? My block-syntax-fu is a bit weak.

[erikchen, 2014-08-15 22:56:26]

https://codereview.chromium.org/481563002/diff/20001/chrome/browser/app_contr...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/481563002/diff/20001/chrome/browser/app_contr...
chrome/browser/app_controller_mac.mm:1557: (void (^)(NSArray*
restorableObjects))restorationHandler {
On 2014/08/15 22:51:00, Avi wrote:
> Do you need the name "restorableObjects" here? My block-syntax-fu is a bit
weak.

We don't. I removed it.

[erikchen, 2014-08-15 22:56:36]

The CQ bit was checked by erikchen@chromium.org

[Avi (use Gerrit), 2014-08-15 22:58:31]

SLGTM

[commit-bot: I haz the power, 2014-08-15 22:59:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/481563002/40001

[commit-bot: I haz the power, 2014-08-16 02:13:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-16 02:17:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-16 02:17:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2014-08-18 17:34:27]

mark: Looking for OWNER review of base/mac
sky: Looking for OWNER review of chrome/app and chrome/browser

[sky, 2014-08-18 18:24:54]

I'm not a good reviewer for these changes: sky->thakis . If thakis says he's too
busy (which is fair because of his status) then we really need some more mac
owners.

[Nico, 2014-08-18 18:36:18]

lgtm

https://codereview.chromium.org/481563002/diff/40001/chrome/browser/app_contr...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/481563002/diff/40001/chrome/browser/app_contr...
chrome/browser/app_controller_mac.mm:1551: return ([userActivityType
isEqualToString:NSUserActivityTypeBrowsingWeb]);
remove pointless parens around this

[Nico, 2014-08-18 18:36:42]

(but more mac users sounds great! Maybe Avi?)


On Mon, Aug 18, 2014 at 11:36 AM, <thakis@chromium.org> wrote:

> lgtm
>
>
> https://codereview.chromium.org/481563002/diff/40001/
> chrome/browser/app_controller_mac.mm
> File chrome/browser/app_controller_mac.mm (right):
>
> https://codereview.chromium.org/481563002/diff/40001/
> chrome/browser/app_controller_mac.mm#newcode1551
> chrome/browser/app_controller_mac.mm:1551: return ([userActivityType
> isEqualToString:NSUserActivityTypeBrowsingWeb]);
> remove pointless parens around this
>
> https://codereview.chromium.org/481563002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-08-18 18:36:59]

Err, "more mac owners" (for ui) :-)


On Mon, Aug 18, 2014 at 11:36 AM, Nico Weber <thakis@chromium.org> wrote:

> (but more mac users sounds great! Maybe Avi?)
>
>
> On Mon, Aug 18, 2014 at 11:36 AM, <thakis@chromium.org> wrote:
>
>> lgtm
>>
>>
>> https://codereview.chromium.org/481563002/diff/40001/
>> chrome/browser/app_controller_mac.mm
>> File chrome/browser/app_controller_mac.mm (right):
>>
>> https://codereview.chromium.org/481563002/diff/40001/
>> chrome/browser/app_controller_mac.mm#newcode1551
>> chrome/browser/app_controller_mac.mm:1551: return ([userActivityType
>> isEqualToString:NSUserActivityTypeBrowsingWeb]);
>> remove pointless parens around this
>>
>> https://codereview.chromium.org/481563002/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[erikchen, 2014-08-18 18:47:57]

https://codereview.chromium.org/481563002/diff/40001/chrome/browser/app_contr...
File chrome/browser/app_controller_mac.mm (right):

https://codereview.chromium.org/481563002/diff/40001/chrome/browser/app_contr...
chrome/browser/app_controller_mac.mm:1551: return ([userActivityType
isEqualToString:NSUserActivityTypeBrowsingWeb]);
On 2014/08/18 18:36:18, Nico (very away) wrote:
> remove pointless parens around this

Done.

[sky, 2014-08-18 19:30:07]

On Mon, Aug 18, 2014 at 11:36 AM, Nico Weber <thakis@chromium.org> wrote:
> (but more mac users sounds great! Maybe Avi?)

+1

>
>
> On Mon, Aug 18, 2014 at 11:36 AM, <thakis@chromium.org> wrote:
>>
>> lgtm
>>
>>
>>
>>
https://codereview.chromium.org/481563002/diff/40001/chrome/browser/app_contr...
>> File chrome/browser/app_controller_mac.mm (right):
>>
>>
>>
https://codereview.chromium.org/481563002/diff/40001/chrome/browser/app_contr...
>> chrome/browser/app_controller_mac.mm:1551: return ([userActivityType
>> isEqualToString:NSUserActivityTypeBrowsingWeb]);
>> remove pointless parens around this
>>
>> https://codereview.chromium.org/481563002/
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[erikchen, 2014-08-18 19:34:47]

Moving mark@ to cc list. thakis is an OWNER of all files in this CL.

[erikchen, 2014-08-18 19:34:56]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-08-18 19:38:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/481563002/60001

[commit-bot: I haz the power, 2014-08-18 21:16:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-18 21:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-18 21:37:46]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[erikchen, 2014-08-18 21:38:45]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2014-08-18 21:40:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erikchen@chromium.org/481563002/60001

[commit-bot: I haz the power, 2014-08-18 22:05:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[commit-bot: I haz the power, 2014-08-18 23:25:32]

Committed patchset #3 (60001) as 290404