Small tweaks and a bug fix.

Small tweaks and a bug fix.

Bug fixed: I was calling paint->canComputeFastBounds() where I should have been calling fSaveStack[i].paint->canComputeFastBounds().

This suggested I factor out the paint adjusting code, now called AdjustForPaint().  This removes the getImageFilter() check for SaveLayers, which seems like an optimization we can add back later if it proves important.

We're going to want to intersect the bounds with the current clip bounds eventually, so might as well land that here too.

Plus, more const.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/479601b9a74b5b8e424ed3d68882e161617bdceb

[mtklein, 2014-08-15 20:23:45]

Little things I stumbled over while bounding ops.

[mtklein, 2014-08-15 20:30:50]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-15 20:31:13]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/481543002/40001

[commit-bot: I haz the power, 2014-08-15 20:31:14]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-16 02:31 UTC

[commit-bot: I haz the power, 2014-08-16 02:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-16 02:31:14]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[robertphillips, 2014-08-18 13:37:55]

lgtm + 2 docs requests

https://codereview.chromium.org/481543002/diff/40001/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/481543002/diff/40001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:271: if (!AdjustForPaint(paint, &rect)) {
I liked the comment that used to go here

https://codereview.chromium.org/481543002/diff/40001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:287: // Nothing can draw outside the current clip.
// clears don't matter in this case because ... ?

[mtklein, 2014-08-18 15:35:06]

https://codereview.chromium.org/481543002/diff/40001/src/core/SkRecordDraw.cpp
File src/core/SkRecordDraw.cpp (right):

https://codereview.chromium.org/481543002/diff/40001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:271: if (!AdjustForPaint(paint, &rect)) {
On 2014/08/18 13:37:55, robertphillips wrote:
> I liked the comment that used to go here

Ooh, agreed.  Done.

https://codereview.chromium.org/481543002/diff/40001/src/core/SkRecordDraw.cp...
src/core/SkRecordDraw.cpp:287: // Nothing can draw outside the current clip.
On 2014/08/18 13:37:55, robertphillips wrote:
> // clears don't matter in this case because ... ?

Done.

[mtklein, 2014-08-18 15:35:11]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-18 15:35:58]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/481543002/60001

[commit-bot: I haz the power, 2014-08-18 15:45:41]

Committed patchset #4 (60001) as 479601b9a74b5b8e424ed3d68882e161617bdceb