Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Side by Side Diff: gyp/common.gypi

Issue 481513004: Define NDEBUG instead of SK_DEBUG/SK_RELEASE. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « experimental/Intersection/QuarticRoot.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2011 The Android Open Source Project 1 # Copyright 2011 The Android Open Source Project
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 # 5 #
6 # This file is automatically included by gyp_skia when building any target. 6 # This file is automatically included by gyp_skia when building any target.
7 7
8 { 8 {
9 'includes': [ 9 'includes': [
10 'common_variables.gypi', 10 'common_variables.gypi',
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 'defines': [ 85 'defines': [
86 'SK_USE_CDB', 86 'SK_USE_CDB',
87 ], 87 ],
88 }, 88 },
89 ], 89 ],
90 [ 'skia_android_framework==0', { 90 [ 'skia_android_framework==0', {
91 # These defines are not used for skia_android_framework, where we build 91 # These defines are not used for skia_android_framework, where we build
92 # one makefile and allow someone to add SK_DEBUG etc for their own 92 # one makefile and allow someone to add SK_DEBUG etc for their own
93 # debugging purposes. 93 # debugging purposes.
94 'configurations': { 94 'configurations': {
95 'Debug': { 95 'Debug': { 'defines': [ 'SK_DEVELOPER=1' ] },
96 'defines': [ 96 'Release': { 'defines': [ 'NDEBUG' ] },
97 'SK_DEBUG',
98 'SK_DEVELOPER=1',
99 ],
100 },
101 'Release': {
102 'defines': [
103 'SK_RELEASE',
104 ],
105 },
106 'Release_Developer': { 97 'Release_Developer': {
107 'inherit_from': ['Release'], 98 'inherit_from': ['Release'],
108 'defines': [ 99 'defines': [ 'SK_DEVELOPER=1' ],
109 'SK_DEVELOPER=1',
110 ],
111 }, 100 },
112 }, 101 },
113 }], 102 }],
114 ], 103 ],
115 }, # end 'target_defaults' 104 }, # end 'target_defaults'
116 } 105 }
OLDNEW
« no previous file with comments | « experimental/Intersection/QuarticRoot.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698