Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 481513002: Changed the test package for chrome_document tests (Closed)

Created:
6 years, 4 months ago by mikecase (-- gone --)
Modified:
6 years, 4 months ago
Reviewers:
aruslan, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changed the test package for chrome_document tests BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289960

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/pylib/constants.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
mikecase (-- gone --)
6 years, 4 months ago (2014-08-15 17:15:57 UTC) #1
jbudorick
lgtm
6 years, 4 months ago (2014-08-15 17:16:11 UTC) #2
mikecase (-- gone --)
The CQ bit was checked by mikecase@chromium.org
6 years, 4 months ago (2014-08-15 17:16:28 UTC) #3
jbudorick
The CQ bit was unchecked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-15 17:18:06 UTC) #4
aruslan
lgtm
6 years, 4 months ago (2014-08-15 17:19:01 UTC) #5
jbudorick
revised: not lgtm, needs to change 'chrome_document', not 'chrome'
6 years, 4 months ago (2014-08-15 17:19:28 UTC) #6
aruslan
On 2014/08/15 17:19:28, jbudorick wrote: > revised: not lgtm, needs to change 'chrome_document', not 'chrome' ...
6 years, 4 months ago (2014-08-15 17:21:20 UTC) #7
jbudorick
lgtm
6 years, 4 months ago (2014-08-15 17:30:33 UTC) #8
mikecase (-- gone --)
The CQ bit was checked by mikecase@chromium.org
6 years, 4 months ago (2014-08-15 17:30:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikecase@chromium.org/481513002/20001
6 years, 4 months ago (2014-08-15 17:32:59 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-15 18:56:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (20001) as 289960

Powered by Google App Engine
This is Rietveld 408576698