Issue 48150: Merge 11965 - Add a handle scope to V8Proxy::initContextIfNeeded....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48150: Merge 11965 - Add a handle scope to V8Proxy::initContextIfNeeded.... (Closed)

Created:
11 years, 9 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/branches/170/src/

Visibility:
Public.

Merge 11965 - Add a handle scope to V8Proxy::initContextIfNeeded. initContextIfNeeded can be called without a handle scope in place which will lead to a renderer crash when creating the first handle. Also V8Proxy::initContextIfNeeded creates a number of local handles that should be deallocated on exit. BUG=8922 Review URL: http://codereview.chromium.org/48131 TBR=ager@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12006

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	webkit/port/bindings/v8/v8_proxy.cpp	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM!