Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 481493002: Revert of Battery Status API: implementation for Windows. (Closed)

Created:
6 years, 4 months ago by timvolodine
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, fmeawad, cpu_(ooo_6.6-7.5)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Battery Status API: implementation for Windows. (patchset #5 of https://codereview.chromium.org/447853002/) Reason for revert: breaking XP Original issue's description: > Battery Status API: implementation for Windows. > > Implementation of the Battery Status API for the Windows platform. > Implementation uses a message window to receive battery notifications. > On versions prior to Vista there is limited support as the > RegisterPowerSettingNotification function is not available. > > BUG=122593 > TEST=http://jsbin.com/battery-status-test (manual) > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289634 TBR=mvanouwerkerk@chromium.org,mlamouri@chromium.org,scottmg@chromium.org,cpu@chromium.org NOTREECHECKS=true NOTRY=true BUG=122593 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -316 lines) Patch
D content/browser/battery_status/battery_status_manager_win.h View 1 chunk +0 lines, -26 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_win.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D content/browser/battery_status/battery_status_manager_win_unittest.cc View 1 chunk +0 lines, -80 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
timvolodine
Created Revert of Battery Status API: implementation for Windows.
6 years, 4 months ago (2014-08-15 16:53:25 UTC) #1
timvolodine
The CQ bit was unchecked by timvolodine@chromium.org
6 years, 4 months ago (2014-08-15 16:54:46 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 4 months ago (2014-08-15 23:21:19 UTC) #3
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 4 months ago (2014-08-15 23:21:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/481493002/1
6 years, 4 months ago (2014-08-15 23:28:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as 290050
6 years, 4 months ago (2014-08-15 23:33:15 UTC) #6
timvolodine
On 2014/08/15 23:33:15, I haz the power (commit-bot) wrote: > Committed patchset #1 (1) as ...
6 years, 4 months ago (2014-08-16 09:36:09 UTC) #7
timvolodine
6 years, 4 months ago (2014-08-16 09:36:46 UTC) #8
Message was sent while issue was closed. 
On 2014/08/16 09:36:09, timvolodine wrote:
> On 2014/08/15 23:33:15, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (1) as 290050
> 
> oh no, this should not have landed!
> the fix was
> here:http://src.chromium.org/viewvc/chrome?revision=289956&view=revision
> relanding now, will probably need to merge for m38 now..

sorry for the confusion

Powered by Google App Engine
This is Rietveld 408576698