Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 481473003: Remove tab_capture_performance_tests isolate and _run target. (Closed)

Created:
6 years, 4 months ago by Ken Russell (switch to Gerrit)
Modified:
6 years, 4 months ago
Reviewers:
jabdelmalek, jam
CC:
chromium-reviews, tonyg, RyanS
Project:
chromium
Visibility:
Public.

Description

Remove tab_capture_performance_tests isolate and _run target. The Perf bots don't invoke these tests via isolates. BUG=401985 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/tab_capture_performance_tests.isolate View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks.
6 years, 4 months ago (2014-08-15 20:13:20 UTC) #1
jabdelmalek
lgtm
6 years, 4 months ago (2014-08-15 20:54:06 UTC) #2
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 4 months ago (2014-08-15 20:56:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/481473003/1
6 years, 4 months ago (2014-08-15 20:59:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-16 00:36:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 00:41:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/4773)
6 years, 4 months ago (2014-08-16 00:41:48 UTC) #7
jam
lgtm
6 years, 4 months ago (2014-08-16 00:43:10 UTC) #8
Ken Russell (switch to Gerrit)
The CQ bit was checked by kbr@chromium.org
6 years, 4 months ago (2014-08-16 00:43:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kbr@chromium.org/481473003/1
6 years, 4 months ago (2014-08-16 00:44:07 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 06:01:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (1) as 290102

Powered by Google App Engine
This is Rietveld 408576698