Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/apps/install_chrome_app.cc

Issue 481433005: Extensions: Move id_util functions to crx_file component. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update GN build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/ephemeral_app_throttle.cc ('k') | chrome/browser/chromeos/app_mode/startup_app_launcher.cc » ('j') | components/crx_file/id_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/install_chrome_app.cc
diff --git a/chrome/browser/apps/install_chrome_app.cc b/chrome/browser/apps/install_chrome_app.cc
index e433991e1a233fd059b79a800938020cbf08e63f..525f31eef5329828bae0d113aa8a5963b331e448 100644
--- a/chrome/browser/apps/install_chrome_app.cc
+++ b/chrome/browser/apps/install_chrome_app.cc
@@ -15,8 +15,8 @@
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/common/extensions/webstore_install_result.h"
+#include "components/crx_file/id_util.h"
#include "extensions/browser/extension_registry.h"
-#include "extensions/common/extension.h"
#include "extensions/common/manifest_constants.h"
using extensions::ExtensionRegistry;
@@ -74,7 +74,7 @@ void WebstoreInstallWithPromptAppsOnly::OnManifestParsed() {
namespace install_chrome_app {
void InstallChromeApp(const std::string& app_id) {
- if (!extensions::Extension::IdIsValid(app_id))
+ if (!crx_file::id_util::IdIsValid(app_id))
return;
// At the moment InstallChromeApp() is called immediately after handling
« no previous file with comments | « chrome/browser/apps/ephemeral_app_throttle.cc ('k') | chrome/browser/chromeos/app_mode/startup_app_launcher.cc » ('j') | components/crx_file/id_util.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698