Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 481433004: [Android] Fix the location prompt flake in provision_devices. (Closed)

Created:
6 years, 4 months ago by jbudorick
Modified:
6 years, 4 months ago
Reviewers:
klundberg, navabi1, tonyg
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix the location prompt flake in provision_devices. BUG=401163 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290353

Patch Set 1 #

Patch Set 2 : pull the 'persist.' property wait from the main CL #

Patch Set 3 : rebase #

Patch Set 4 : fix typos #

Patch Set 5 : pull exception handling from main review #

Patch Set 6 : rebase + remove persist property changes. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -68 lines) Patch
M build/android/provision_devices.py View 1 2 3 4 7 chunks +27 lines, -13 lines 0 comments Download
M build/android/pylib/device_settings.py View 1 2 3 4 5 4 chunks +61 lines, -55 lines 1 comment Download

Messages

Total messages: 13 (0 generated)
jbudorick
6 years, 4 months ago (2014-08-15 19:15:28 UTC) #1
tonyg
lgtm
6 years, 4 months ago (2014-08-15 19:17:13 UTC) #2
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-18 14:42:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/481433004/40001
6 years, 4 months ago (2014-08-18 14:43:20 UTC) #4
jbudorick
The CQ bit was unchecked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-18 15:17:05 UTC) #5
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-18 15:49:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/481433004/60001
6 years, 4 months ago (2014-08-18 15:50:04 UTC) #7
jbudorick
The CQ bit was unchecked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-18 16:23:38 UTC) #8
navabi1
lgtm Thanks John! Great work.
6 years, 4 months ago (2014-08-18 17:22:58 UTC) #9
jbudorick
https://codereview.chromium.org/481433004/diff/100001/build/android/pylib/device_settings.py File build/android/pylib/device_settings.py (right): https://codereview.chromium.org/481433004/diff/100001/build/android/pylib/device_settings.py#newcode40 build/android/pylib/device_settings.py:40: device.old_interface.WaitForDevicePm() I removed the change I had here to ...
6 years, 4 months ago (2014-08-18 19:00:33 UTC) #10
jbudorick
The CQ bit was checked by jbudorick@chromium.org
6 years, 4 months ago (2014-08-18 19:46:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/481433004/100001
6 years, 4 months ago (2014-08-18 19:48:26 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 20:34:49 UTC) #13
Message was sent while issue was closed. 
Committed patchset #6 (100001) as 290353

Powered by Google App Engine
This is Rietveld 408576698