Source/core/html/canvas/WebGLRenderingContextBase.cpp - Issue 481433002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.cpp

Issue 481433002: gpu: Remove WebGraphicsContext3D::makeContextCurrent() in Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase to ToT Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/canvas/WebGLRenderingContextBase.cpp

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.cpp b/Source/core/html/canvas/WebGLRenderingContextBase.cpp

index 2ce5ec217924c6997ca4d48bff875dfbc0a155ba..1e3d283beee62e52158bd5113423e1408b914dee 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.cpp

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.cpp

@@ -5511,7 +5511,7 @@ void WebGLRenderingContextBase::maybeRestoreContext(Timer<WebGLRenderingContextB

OwnPtr<blink::WebGraphicsContext3D> context = adoptPtr(blink::Platform::current()->createOffscreenGraphicsContext3D(attributes, 0));

RefPtr<DrawingBuffer> buffer;

// Even if a non-null WebGraphicsContext3D is created, until it's made current, it isn't known whether the context is still lost.

- if (context) {

+ if (context && context->makeContextCurrent()) {

// Construct a new drawing buffer with the new WebGraphicsContext3D.

buffer = createDrawingBuffer(context.release());

// If DrawingBuffer::create() fails to allocate a fbo, |drawingBuffer| is set to null.

« no previous file with comments | « Source/core/html/HTMLVideoElement.cpp ('k') | Source/platform/graphics/Canvas2DLayerBridge.cpp » ('j') | no next file with comments »