Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: webkit/port/bindings/v8/v8_proxy.cpp

Issue 48131: Add a handle scope to V8Proxy::initContextIfNeeded.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/bindings/v8/v8_proxy.cpp
===================================================================
--- webkit/port/bindings/v8/v8_proxy.cpp (revision 11860)
+++ webkit/port/bindings/v8/v8_proxy.cpp (working copy)
@@ -2375,6 +2375,9 @@
if (!m_context.IsEmpty())
return;
+ // Create a handle scope for all local handles.
+ v8::HandleScope handle_scope;
+
// Setup the security handlers and message listener. This only has
// to be done once.
static bool v8_initialized = false;
@@ -2400,7 +2403,7 @@
// Starting from now, use local context only.
v8::Local<v8::Context> context = GetContext();
- v8::Context::Scope scope(context);
+ v8::Context::Scope context_scope(context);
// Store the first global object created so we can reuse it.
if (m_global.IsEmpty()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698