Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 481303002: Update the position of autocomplete list after the model is updated. (Closed)

Created:
6 years, 4 months ago by fukino
Modified:
6 years, 4 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update the position of autocomplete list after the model is updated. When a user put one letter on search box, the position of autocomplete list is calculated incorrectly. It's because the position is updated before the model (the list content) is updated, so the position is calculated assuming that the list is empty. This can be fixed by updating the position after the model is updated. BUG=404057 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fukino
@yoshiki - could you take a look? This solves the second problem described in the ...
6 years, 4 months ago (2014-08-19 05:26:35 UTC) #1
yoshiki
lgtm
6 years, 4 months ago (2014-08-20 02:05:30 UTC) #2
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 4 months ago (2014-08-20 02:25:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/481303002/1
6 years, 4 months ago (2014-08-20 02:26:16 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 03:32:49 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 03:53:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290746

Powered by Google App Engine
This is Rietveld 408576698