Issue 48123003: Create services subdir under chrome/browser and add initial owners

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48123003: Create services subdir under chrome/browser and add initial owners (Closed)

Created:
7 years, 1 month ago by jianli

Modified:
7 years, 1 month ago

Reviewers:
Nico, tim (not reviewing)

CC:
chromium-reviews, Nicolas Zea

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Create services subdir under chrome/browser and add initial owners The new services subdir contains all google services related codes, currently including sync, invalidation and signin. We will move those codes to this new unified directory in future patches. BUG=314886 TEST=none R=thakis@chromium.org, tim@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233030

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	A	chrome/browser/services/OWNERS	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

Nico

Can you file a tracking bug for moving things around, and reference that in all ...

7 years, 1 month ago (2013-11-05 00:04:38 UTC) #2

jianli

On 2013/11/05 00:04:38, Nico wrote: > Can you file a tracking bug for moving things ...

7 years, 1 month ago (2013-11-05 00:15:45 UTC) #3

tim (not reviewing)

LGTM, we'll want to add owners as the subdirs are moved over.

7 years, 1 month ago (2013-11-05 18:19:56 UTC) #5

jianli

7 years, 1 month ago (2013-11-05 18:22:11 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r233030 (presubmit successful).