Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(955)

Unified Diff: media/audio/audio_io.h

Issue 481193003: Remove AudioBuffersState usage in Chromium (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix silly build buster Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_io.h
diff --git a/media/audio/audio_io.h b/media/audio/audio_io.h
index 1e1eba420b14aa049bacbf91a9841ec452e1c6ed..f8fd07a59770aeedf317c559aa4da4d36e661fde 100644
--- a/media/audio/audio_io.h
+++ b/media/audio/audio_io.h
@@ -58,10 +58,16 @@ class MEDIA_EXPORT AudioOutputStream {
class MEDIA_EXPORT AudioSourceCallback {
public:
// Provide more data by fully filling |dest|. The source will return
- // the number of frames it filled. |buffers_state| contains current state
- // of the buffers, and can be used by the source to calculate delay.
- virtual int OnMoreData(AudioBus* dest,
- AudioBuffersState buffers_state) = 0;
+ // the number of frames it filled. |total_bytes_delay| contains current
+ // number of bytes of delay buffered by the AudioOutputStream.
+ //
+ // TODO(acolwell): Remove default implementation of this method once
+ // the AudioBuffersState version below is removed.
+ virtual int OnMoreData(AudioBus* dest, int total_bytes_delay);
+
+ // TODO(acolwell): Remove this once all dependencies on AudioBufferState
+ // that are outside the main Chromium repository have been removed.
+ virtual int OnMoreData(AudioBus* dest, AudioBuffersState buffers_state);
// There was an error while playing a buffer. Audio source cannot be
// destroyed yet. No direct action needed by the AudioStream, but it is

Powered by Google App Engine
This is Rietveld 408576698