Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: media/audio/audio_output_resampler.cc

Issue 481193003: Remove AudioBuffersState usage in Chromium (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix audio muter build buster. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/audio_output_resampler.h ('k') | media/audio/cras/cras_unified.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/audio_output_resampler.cc
diff --git a/media/audio/audio_output_resampler.cc b/media/audio/audio_output_resampler.cc
index 5926996eced3c0805855f48cbb2882aa730bc24f..42c2ea89b4990cad95c23dfea55f38bfb5028873 100644
--- a/media/audio/audio_output_resampler.cc
+++ b/media/audio/audio_output_resampler.cc
@@ -8,6 +8,7 @@
#include "base/bind_helpers.h"
#include "base/compiler_specific.h"
#include "base/metrics/histogram.h"
+#include "base/numerics/safe_conversions.h"
#include "base/single_thread_task_runner.h"
#include "base/time/time.h"
#include "build/build_config.h"
@@ -30,7 +31,7 @@ class OnMoreDataConverter
// AudioSourceCallback interface.
virtual int OnMoreData(AudioBus* dest,
- AudioBuffersState buffers_state) OVERRIDE;
+ uint32 total_bytes_delay) OVERRIDE;
virtual void OnError(AudioOutputStream* stream) OVERRIDE;
// Sets |source_callback_|. If this is not a new object, then Stop() must be
@@ -54,9 +55,9 @@ class OnMoreDataConverter
// Source callback.
AudioOutputStream::AudioSourceCallback* source_callback_;
- // Last AudioBuffersState object received via OnMoreData(), used to correct
+ // Last |total_bytes_delay| received via OnMoreData(), used to correct
// playback delay by ProvideInput() and passed on to |source_callback_|.
- AudioBuffersState current_buffers_state_;
+ uint32 current_total_bytes_delay_;
const int input_bytes_per_second_;
@@ -327,8 +328,8 @@ void OnMoreDataConverter::Stop() {
}
int OnMoreDataConverter::OnMoreData(AudioBus* dest,
- AudioBuffersState buffers_state) {
- current_buffers_state_ = buffers_state;
+ uint32 total_bytes_delay) {
+ current_total_bytes_delay_ = total_bytes_delay;
audio_converter_.Convert(dest);
// Always return the full number of frames requested, ProvideInput()
@@ -341,13 +342,12 @@ double OnMoreDataConverter::ProvideInput(AudioBus* dest,
// Adjust playback delay to include |buffer_delay|.
// TODO(dalecurtis): Stop passing bytes around, it doesn't make sense since
// AudioBus is just float data. Use TimeDelta instead.
- AudioBuffersState new_buffers_state;
- new_buffers_state.pending_bytes =
- io_ratio_ * (current_buffers_state_.total_bytes() +
- buffer_delay.InSecondsF() * input_bytes_per_second_);
+ uint32 new_total_bytes_delay = base::saturated_cast<uint32>(
+ io_ratio_ * (current_total_bytes_delay_ +
+ buffer_delay.InSecondsF() * input_bytes_per_second_));
// Retrieve data from the original callback.
- const int frames = source_callback_->OnMoreData(dest, new_buffers_state);
+ const int frames = source_callback_->OnMoreData(dest, new_total_bytes_delay);
// Zero any unfilled frames if anything was filled, otherwise we'll just
// return a volume of zero and let AudioConverter drop the output.
« no previous file with comments | « media/audio/audio_output_resampler.h ('k') | media/audio/cras/cras_unified.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698