Reuse the eula terms from the chrome resources...

Reuse the eula terms from the chrome resources
- that outta reduce the fat that setup.exe gained
- this is the chrome side of the fix

BUG=8894
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12046

[Glenn Wilson, 2009-03-18 01:43:23]

http://codereview.chromium.org/48114/diff/1/2
File chrome/browser/first_run.cc (right):

http://codereview.chromium.org/48114/diff/1/2#newcode241
Line 241: if (WriteEULAtoTempFile(&inner_html)) {
If the EULA is empty (language not supported?) or the temp dir is not available,
shouldn't we exit?  Could I circumvent the EULA by just deleting my temp dir
environment variable or choosing an unsupported language?

[cpu_(ooo_6.6-7.5), 2009-03-18 05:33:20]

http://codereview.chromium.org/48114/diff/1/2
File chrome/browser/first_run.cc (right):

http://codereview.chromium.org/48114/diff/1/2#newcode241
Line 241: if (WriteEULAtoTempFile(&inner_html)) {
On 2009/03/18 01:43:24, gwilson wrote:
> If the EULA is empty (language not supported?) or the temp dir is not
available,
> shouldn't we exit?  Could I circumvent the EULA by just deleting my temp dir

The temp dir is given by a window api which does not rely on the env var. But I
guess you might be able to mess with it somehow.

The fallback looks like is English, so looks like you should always get
something (even in chromium build you get something !!) unless for some reason
we fail to write the file.

We could to ::ExitProcess(1) as we do in line 247 if you like.


> environment variable or choosing an unsupported language?

[Mark Larson, 2009-03-18 05:36:17]

OK with me.

[Glenn Wilson, 2009-03-18 16:58:52]

LGTM then.