Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 48114: Reuse the eula terms from the chrome resources... (Closed)

Created:
11 years, 9 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, huanr
Visibility:
Public.

Description

Reuse the eula terms from the chrome resources - that outta reduce the fat that setup.exe gained - this is the chrome side of the fix BUG=8894 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=12046

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -23 lines) Patch
M chrome/browser/browser_main.cc View 2 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/first_run.cc View 6 chunks +38 lines, -14 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
cpu_(ooo_6.6-7.5)
11 years, 9 months ago (2009-03-18 00:51:11 UTC) #1
Glenn Wilson
http://codereview.chromium.org/48114/diff/1/2 File chrome/browser/first_run.cc (right): http://codereview.chromium.org/48114/diff/1/2#newcode241 Line 241: if (WriteEULAtoTempFile(&inner_html)) { If the EULA is empty ...
11 years, 9 months ago (2009-03-18 01:43:23 UTC) #2
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/48114/diff/1/2 File chrome/browser/first_run.cc (right): http://codereview.chromium.org/48114/diff/1/2#newcode241 Line 241: if (WriteEULAtoTempFile(&inner_html)) { On 2009/03/18 01:43:24, gwilson wrote: ...
11 years, 9 months ago (2009-03-18 05:33:20 UTC) #3
Mark Larson
OK with me.
11 years, 9 months ago (2009-03-18 05:36:17 UTC) #4
Glenn Wilson
11 years, 9 months ago (2009-03-18 16:58:52 UTC) #5
LGTM then.

Powered by Google App Engine
This is Rietveld 408576698