Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/common/extensions/api/app_window.idl

Issue 48113024: Allow chrome.app.window alwaysOnTop property in stable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use camel case for other parameter names in app_window.idl Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/_api_features.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/app_window.idl
diff --git a/chrome/common/extensions/api/app_window.idl b/chrome/common/extensions/api/app_window.idl
index 65f34f853cb615a80bfe16a6ea0cf52301429073..fe5cf9b0247fc51de327c6e012964d8ca1523410 100644
--- a/chrome/common/extensions/api/app_window.idl
+++ b/chrome/common/extensions/api/app_window.idl
@@ -108,19 +108,18 @@ namespace app.window {
// multiple windows of this kind, the currently focused window will be in
// the foreground. Defaults to false. Call <code>setAlwaysOnTop()</code> on
// the window to change this property after creation.
- // Currently available in the Dev channel only.
boolean? alwaysOnTop;
};
// Called in the creating window (parent) before the load event is called in
// the created window (child). The parent can set fields or functions on the
// child usable from onload. E.g. background.js:<br>
- // <code>function(created_window) { created_window.contentWindow.foo =
+ // <code>function(createdWindow) { createdWindow.contentWindow.foo =
// function () { }; };</code>
// <br>window.js:<br>
// <code>window.onload = function () { foo(); }</code>
callback CreateWindowCallback =
- void ([instanceOf=AppWindow] object created_window);
+ void ([instanceOf=AppWindow] object createdWindow);
[noinline_doc] dictionary AppWindow {
// Focus the window.
@@ -177,15 +176,13 @@ namespace app.window {
// Set the app icon for the window (experimental).
// Currently this is only being implemented on Ash.
// TODO(stevenjb): Investigate implementing this on Windows and OSX.
- [nodoc] static void setIcon(DOMString icon_url);
+ [nodoc] static void setIcon(DOMString iconUrl);
// Is the window always on top?
- // Currently available in the Dev channel only.
static boolean isAlwaysOnTop();
// Set whether the window should stay above most other windows.
- // Currently available in the Dev channel only.
- static void setAlwaysOnTop(boolean always_on_top);
+ static void setAlwaysOnTop(boolean alwaysOnTop);
// The JavaScript 'window' object for the created child.
[instanceOf=Window] object contentWindow;
« no previous file with comments | « chrome/common/extensions/api/_api_features.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698