Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 48113024: Allow chrome.app.window alwaysOnTop property in stable (Closed)

Created:
7 years, 1 month ago by tmdiep
Modified:
7 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Allow chrome.app.window alwaysOnTop property in stable Removed dev channel restriction, allow the alwaysOnTop property in M32 stable. BUG=171597 TEST=Test all OSes using Window State sample app. Create windows with the alwaysOnTop option enabled, as well as changing the property using the setAlwaysOnTop() API function after window creation. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232001

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use camel case for other parameter names in app_window.idl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/app_window.idl View 1 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tmdiep
Ben: Please review this patch, thanks.
7 years, 1 month ago (2013-10-30 00:33:20 UTC) #1
benwells
lgtm https://codereview.chromium.org/48113024/diff/1/chrome/common/extensions/api/app_window.idl File chrome/common/extensions/api/app_window.idl (right): https://codereview.chromium.org/48113024/diff/1/chrome/common/extensions/api/app_window.idl#newcode185 chrome/common/extensions/api/app_window.idl:185: static void setAlwaysOnTop(boolean alwaysOnTop); Ah, nice catch. Camel ...
7 years, 1 month ago (2013-10-30 06:08:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/48113024/100001
7 years, 1 month ago (2013-10-30 22:42:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/48113024/100001
7 years, 1 month ago (2013-10-30 23:19:55 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 04:32:46 UTC) #5
Message was sent while issue was closed.
Change committed as 232001

Powered by Google App Engine
This is Rietveld 408576698