Class to list only printers that support local printing

Class to list only printers that support local printing

An adapter for PrivetDeviceLister that checks /privet/info and outputs only
devices that support /privet/printer/submitdoc.

BUG=311390
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233340

[Vitaly Buka (NO REVIEWS), 2013-10-31 09:26:03]

lgtm

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/privet_local_printer_lister.h (right):

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_local_printer_lister.h:42: virtual void
DeviceChanged(bool added,
Please put comments winch method override winch interface

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_local_printer_lister.h:54: class
DeviceContext {
you can set 

class DeviceContext; here and define class in cc file and remove some includes
from here

[Vitaly Buka (NO REVIEWS), 2013-10-31 09:26:22]

On 2013/10/31 09:26:03, Vitaly Buka wrote:
> lgtm
> 
>
https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
> File chrome/browser/local_discovery/privet_local_printer_lister.h (right):
> 
>
https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
> chrome/browser/local_discovery/privet_local_printer_lister.h:42: virtual void
> DeviceChanged(bool added,
> Please put comments winch method override winch interface
> 
>
https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
> chrome/browser/local_discovery/privet_local_printer_lister.h:54: class
> DeviceContext {
> you can set 
> 
> class DeviceContext; here and define class in cc file and remove some includes
> from here

BUG?

[gene, 2013-10-31 18:47:43]

lgtm

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/privet_local_printer_lister.h (right):

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_local_printer_lister.h:54: class
DeviceContext {
+1 Vitaly's comment

[Vitaly Buka (NO REVIEWS), 2013-10-31 18:53:20]

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/privet_local_printer_lister.h (right):

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_local_printer_lister.h:54: class
DeviceContext {
our style guide requires class->struct here
On 2013/10/31 18:47:43, gene wrote:
> +1 Vitaly's comment

[Noam Samuel, 2013-10-31 20:08:06]

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
File chrome/browser/local_discovery/privet_local_printer_lister.h (right):

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_local_printer_lister.h:42: virtual void
DeviceChanged(bool added,
On 2013/10/31 09:26:03, Vitaly Buka wrote:
> Please put comments winch method override winch interface

Done

https://codereview.chromium.org/48113019/diff/1/chrome/browser/local_discover...
chrome/browser/local_discovery/privet_local_printer_lister.h:54: class
DeviceContext {
On 2013/10/31 18:53:20, Vitaly Buka wrote:
> our style guide requires class->struct here
> On 2013/10/31 18:47:43, gene wrote:
> > +1 Vitaly's comment
> 

Done on both.

[commit-bot: I haz the power, 2013-10-31 20:12:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/48113019/90001

[commit-bot: I haz the power, 2013-10-31 20:12:54]

Failed to apply patch for chrome/browser/local_discovery/privet_http_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/local_discovery/privet_http_impl.cc
  Hunk #2 FAILED at 235.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/local_discovery/privet_http_impl.cc.rej

Patch:       chrome/browser/local_discovery/privet_http_impl.cc
Index: chrome/browser/local_discovery/privet_http_impl.cc
diff --git a/chrome/browser/local_discovery/privet_http_impl.cc
b/chrome/browser/local_discovery/privet_http_impl.cc
index
c236255a50e4daee1c44a889b505b6a16db842d7..28575a36c7623d1c4901119251403e9935c3d8b4
100644
--- a/chrome/browser/local_discovery/privet_http_impl.cc
+++ b/chrome/browser/local_discovery/privet_http_impl.cc
@@ -18,12 +18,6 @@ const char kUrlPlaceHolder[] = "http://host/";
 const char kPrivetRegisterActionArgName[] = "action";
 const char kPrivetRegisterUserArgName[] = "user";
 
-const char kPrivetInfoPath[] = "/privet/info";
-const char kPrivetRegisterPath[] = "/privet/register";
-const char kPrivetCapabilitiesPath[] = "/privet/capabilities";
-const char kPrivetSubmitdocPath[] = "/privet/printer/submitdoc";
-const char kPrivetCreatejobPath[] = "/privet/printer/createjob";
-
 const char kPrivetURLKeyUser[] = "user";
 const char kPrivetURLKeyJobname[] = "jobname";
 const char kPrivetURLKeyOffline[] = "offline";
@@ -241,7 +235,7 @@ void PrivetRegisterOperationImpl::OnPrivetInfoDone(
     PrivetInfoOperation* operation,
     int http_code,
     const base::DictionaryValue* value) {
-   // TODO (noamsml): Simplify error case.
+  // TODO(noamsml): Simplify error case.
   if (!value) {
     delegate_->OnPrivetRegisterError(this,
                                      kPrivetActionNameInfo,

[commit-bot: I haz the power, 2013-10-31 23:27:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/48113019/150001

[commit-bot: I haz the power, 2013-10-31 23:28:01]

Failed to apply patch for chrome/browser/local_discovery/privet_http_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/local_discovery/privet_http_impl.cc
  Hunk #2 FAILED at 235.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/local_discovery/privet_http_impl.cc.rej

Patch:       chrome/browser/local_discovery/privet_http_impl.cc
Index: chrome/browser/local_discovery/privet_http_impl.cc
diff --git a/chrome/browser/local_discovery/privet_http_impl.cc
b/chrome/browser/local_discovery/privet_http_impl.cc
index
c236255a50e4daee1c44a889b505b6a16db842d7..28575a36c7623d1c4901119251403e9935c3d8b4
100644
--- a/chrome/browser/local_discovery/privet_http_impl.cc
+++ b/chrome/browser/local_discovery/privet_http_impl.cc
@@ -18,12 +18,6 @@ const char kUrlPlaceHolder[] = "http://host/";
 const char kPrivetRegisterActionArgName[] = "action";
 const char kPrivetRegisterUserArgName[] = "user";
 
-const char kPrivetInfoPath[] = "/privet/info";
-const char kPrivetRegisterPath[] = "/privet/register";
-const char kPrivetCapabilitiesPath[] = "/privet/capabilities";
-const char kPrivetSubmitdocPath[] = "/privet/printer/submitdoc";
-const char kPrivetCreatejobPath[] = "/privet/printer/createjob";
-
 const char kPrivetURLKeyUser[] = "user";
 const char kPrivetURLKeyJobname[] = "jobname";
 const char kPrivetURLKeyOffline[] = "offline";
@@ -241,7 +235,7 @@ void PrivetRegisterOperationImpl::OnPrivetInfoDone(
     PrivetInfoOperation* operation,
     int http_code,
     const base::DictionaryValue* value) {
-   // TODO (noamsml): Simplify error case.
+  // TODO(noamsml): Simplify error case.
   if (!value) {
     delegate_->OnPrivetRegisterError(this,
                                      kPrivetActionNameInfo,

[commit-bot: I haz the power, 2013-11-04 18:20:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/48113019/150001

[commit-bot: I haz the power, 2013-11-04 18:57:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-05 00:21:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/48113019/410001

[commit-bot: I haz the power, 2013-11-05 01:59:52]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-06 00:10:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/48113019/660001

[commit-bot: I haz the power, 2013-11-06 04:44:14]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-06 05:31:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/48113019/660001

[commit-bot: I haz the power, 2013-11-06 08:52:45]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 17:28:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/48113019/660001

[commit-bot: I haz the power, 2013-11-06 20:29:51]

Change committed as 233340