Adjust app windows to play nice with NVHA fast resize CL

Adjust app windows to play nice with NVHA fast resize CL

This CL changes the test in
NativeAppWindowViews::ShouldDescendIntoChildForEventHandling from being
child is equal to child contains. This is done since the NVHA CL,
https://codereview.chromium.org/48113013, introduces a window between
the top level and the child to do clipping, so the old condition will
never be satisfied. This has been broken out into its own CL to reduce
the scope of the NVHA CL.

BUG=282463
BUG=312201
BUG=311895
TEST=Confirmed that the window app sample works correctly with and
     without NVHA CL.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231619

[rharrison, 2013-10-28 21:02:05]

PTAL

[sadrul, 2013-10-28 21:07:19]

lgtm

This should have a test. There doesn't appear to be NativeAppWindowViewsTest, or
ShellWindowTest. So I am not sure where this test would go. benwells@ might have
a suggestion.

[benwells, 2013-10-28 21:12:08]

+cc mlamouri

lgtm

Testing for these windows has been implemented at the extension API level .. but
those tests are all disabled.

We're working on re-enabling them. We could also do with more direct testing
(i.e. unit or browser tests) - please file a bug on mlamouri@ and myself to do
this. If you could provide an example of how to test this kind of change that
would be awesome.

[rharrison, 2013-10-29 13:40:42]

On 2013/10/28 21:12:08, benwells wrote:
> +cc mlamouri
> 
> lgtm
> 
> Testing for these windows has been implemented at the extension API level ..
but
> those tests are all disabled.
> 
> We're working on re-enabling them. We could also do with more direct testing
> (i.e. unit or browser tests) - please file a bug on mlamouri@ and myself to do
> this. If you could provide an example of how to test this kind of change that
> would be awesome.

I have create http://crbug.com/312726 which includes my suggestion for testing
that should be done for this specific situation.

[commit-bot: I haz the power, 2013-10-29 13:46:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rharrison@chromium.org/48113014/240001

[commit-bot: I haz the power, 2013-10-29 17:18:34]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-29 17:25:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rharrison@chromium.org/48113014/240001

[commit-bot: I haz the power, 2013-10-29 19:52:56]

Change committed as 231619