Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: Source/platform/fonts/FontMetrics.h

Issue 48113009: Move Font related classes to Source/platform/fonts (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add two more Font related independent files Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/fonts/FontMetrics.h
diff --git a/Source/core/platform/graphics/FontMetrics.h b/Source/platform/fonts/FontMetrics.h
similarity index 97%
rename from Source/core/platform/graphics/FontMetrics.h
rename to Source/platform/fonts/FontMetrics.h
index dbf1636a6bc6496b1873b859b593e35d248840e9..4f8414b095319b35b8106150eff9c2dd424a7e89 100644
--- a/Source/core/platform/graphics/FontMetrics.h
+++ b/Source/platform/fonts/FontMetrics.h
@@ -27,7 +27,7 @@ namespace WebCore {
const unsigned gDefaultUnitsPerEm = 1000;
-class FontMetrics {
+class PLATFORM_EXPORT FontMetrics {
abarth-chromium 2013/10/29 05:26:35 This class looks entirely inline. There's no reas
rwlbuis 2013/10/29 18:38:00 Fixed.
public:
FontMetrics()
: m_unitsPerEm(gDefaultUnitsPerEm)
@@ -147,7 +147,7 @@ private:
bool m_hasZeroWidth;
};
-static inline float scaleEmToUnits(float x, unsigned unitsPerEm)
+PLATFORM_EXPORT inline float scaleEmToUnits(float x, unsigned unitsPerEm)
abarth-chromium 2013/10/29 05:26:35 This function is inline. It's nonsense to try to
rwlbuis 2013/10/29 18:38:00 Fixed.
{
return unitsPerEm ? x / unitsPerEm : x;
}

Powered by Google App Engine
This is Rietveld 408576698