Move Font related classes to Source/platform/fonts

Move Font related classes to Source/platform/fonts

BUG=297477
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160880

[rwlbuis, 2013-10-28 19:35:12]

Fairly straightforward move of Font related classes. Stuff like FontCache still
relies to much on Font.h to move.

[Stephen Chennney, 2013-10-28 20:22:21]

On 2013/10/28 19:35:12, rwlbuis wrote:
> Fairly straightforward move of Font related classes. Stuff like FontCache
still
> relies to much on Font.h to move.

Can't do this. SimpleFontData relies on core/css. Can't move headers without
moving CPP files.

[Stephen Chennney, 2013-10-28 20:28:07]

On 2013/10/28 20:22:21, Stephen Chenney wrote:
> On 2013/10/28 19:35:12, rwlbuis wrote:
> > Fairly straightforward move of Font related classes. Stuff like FontCache
> still
> > relies to much on Font.h to move.
> 
> Can't do this. SimpleFontData relies on core/css. Can't move headers without
> moving CPP files.

Oops. Not an issue here. Although I already had a patch up for these files,
which I'm happy to abandon. IIRC I was blocked on moving the FontFamilyNames
code generation, which is now done.

[abarth-chromium, 2013-10-29 05:26:34]

LGTM, but there are a few details to polish before landing this CL.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
File Source/platform/fonts/FontCacheKey.h (right):

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontCacheKey.h:45: struct PLATFORM_EXPORT FontCacheKey {
Don't we need to #include "platform/PlatformExport.h" ?  I don't see any headers
that would pull that in.

Actually, this class is entirely inline.  There's no reason to export it (and
there's no complication unit to export it from anyway).

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontCacheKey.h:111: struct PLATFORM_EXPORT
FontCacheKeyTraits : WTF::SimpleClassHashTraits<FontCacheKey> { };
This class looks entirely inline.  I don't think there's a reason to export it.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
File Source/platform/fonts/FontMetrics.h (right):

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontMetrics.h:30: class PLATFORM_EXPORT FontMetrics {
This class looks entirely inline.  There's no reason to export it.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontMetrics.h:150: PLATFORM_EXPORT inline float
scaleEmToUnits(float x, unsigned unitsPerEm)
This function is inline.  It's nonsense to try to export it.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
File Source/platform/fonts/FontSelector.h (right):

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontSelector.h:39: class PLATFORM_EXPORT FontSelector :
public RefCounted<FontSelector> {
Again, this class is entirely inline.  If you need to export this class to make
windows happy, you can make a FontSelector.cpp file to hold ~FontSelector

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontSelector.h:53: class PLATFORM_EXPORT
FontSelectorClient {
ditto

[commit-bot: I haz the power, 2013-10-29 18:36:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/48113009/130001

[rwlbuis, 2013-10-29 18:37:59]

The new patch is rebased against ToT and should fix the mentioned export issues.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
File Source/platform/fonts/FontCacheKey.h (right):

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontCacheKey.h:45: struct PLATFORM_EXPORT FontCacheKey {
On 2013/10/29 05:26:35, abarth wrote:
> Don't we need to #include "platform/PlatformExport.h" ?  I don't see any
headers
> that would pull that in.
> 
> Actually, this class is entirely inline.  There's no reason to export it (and
> there's no complication unit to export it from anyway).

Ok, good point.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontCacheKey.h:111: struct PLATFORM_EXPORT
FontCacheKeyTraits : WTF::SimpleClassHashTraits<FontCacheKey> { };
On 2013/10/29 05:26:35, abarth wrote:
> This class looks entirely inline.  I don't think there's a reason to export
it.

Fixed.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
File Source/platform/fonts/FontMetrics.h (right):

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontMetrics.h:30: class PLATFORM_EXPORT FontMetrics {
On 2013/10/29 05:26:35, abarth wrote:
> This class looks entirely inline.  There's no reason to export it.

Fixed.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontMetrics.h:150: PLATFORM_EXPORT inline float
scaleEmToUnits(float x, unsigned unitsPerEm)
On 2013/10/29 05:26:35, abarth wrote:
> This function is inline.  It's nonsense to try to export it.

Fixed.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
File Source/platform/fonts/FontSelector.h (right):

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontSelector.h:39: class PLATFORM_EXPORT FontSelector :
public RefCounted<FontSelector> {
On 2013/10/29 05:26:35, abarth wrote:
> Again, this class is entirely inline.  If you need to export this class to
make
> windows happy, you can make a FontSelector.cpp file to hold ~FontSelector

I'll try without the export first.

https://codereview.chromium.org/48113009/diff/60001/Source/platform/fonts/Fon...
Source/platform/fonts/FontSelector.h:53: class PLATFORM_EXPORT
FontSelectorClient {
On 2013/10/29 05:26:35, abarth wrote:
> ditto

ditto :)

[commit-bot: I haz the power, 2013-10-29 19:29:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/48113009/240001

[commit-bot: I haz the power, 2013-10-29 20:51:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_blink_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-29 21:02:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/48113009/360001

[commit-bot: I haz the power, 2013-10-30 00:09:48]

Change committed as 160880