Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: net/url_request/url_request_file_dir_job.cc

Issue 48113006: Fix scoping of raw_bytes in URLRequestFileDirJob::OnListFile (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use AppendASCII in unittest Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/data/url_request_unittest/filedir-sentinel ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_file_dir_job.cc
diff --git a/net/url_request/url_request_file_dir_job.cc b/net/url_request/url_request_file_dir_job.cc
index 39093701095232131254fa78661286c660f2f7c4..d98da02ae9136b2431d0605691c07fbdd895f464 100644
--- a/net/url_request/url_request_file_dir_job.cc
+++ b/net/url_request/url_request_file_dir_job.cc
@@ -119,7 +119,8 @@ void URLRequestFileDirJob::OnListFile(
std::string raw_bytes; // Empty on Windows means UTF-8 encoded name.
#elif defined(OS_POSIX)
// TOOD(jungshik): The same issue as for the directory name.
- const std::string& raw_bytes = data.info.GetName().value();
+ base::FilePath filename = data.info.GetName();
+ const std::string& raw_bytes = filename.value();
#endif
data_.append(GetDirectoryListingEntry(
data.info.GetName().LossyDisplayName(),
« no previous file with comments | « net/data/url_request_unittest/filedir-sentinel ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698