Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 481053002: Move SkReadBuffer.h and SkReader32.h out of include. (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : second_try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -406 lines) Patch
M experimental/webtry/templates/template.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 2 chunks +2 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
D include/core/SkFlattenableBuffers.h View 1 1 chunk +1 line, -9 lines 0 comments Download
D include/core/SkReadBuffer.h View 1 chunk +0 lines, -235 lines 0 comments Download
D include/core/SkReader32.h View 1 chunk +0 lines, -160 lines 0 comments Download
A + src/core/SkReadBuffer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/core/SkReader32.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/ImageFilterTest.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
hal.canary
ptal
6 years, 4 months ago (2014-08-18 16:47:34 UTC) #1
reed1
privatization always good -- lgtm
6 years, 4 months ago (2014-08-18 17:02:15 UTC) #2
mtklein
On 2014/08/18 17:02:15, reed1 wrote: > privatization always good -- lgtm https://code.google.com/p/chromium/codesearch#chromium/src/skia/ext/pixel_ref_utils_unittest.cc&q=SkFlattenableBuffers.h%20-src/third_party&sq=package:chromium&type=cs&l=13 :(
6 years, 4 months ago (2014-08-18 17:10:50 UTC) #3
hal.canary
On 2014/08/18 17:10:50, mtklein wrote: > https://code.google.com/p/chromium/codesearch#chromium/src/skia/ext/pixel_ref_utils_unittest.cc&q=SkFlattenableBuffers.h%20-src/third_party&sq=package:chromium&type=cs&l=13 > > :( http://crrev.com/478383002
6 years, 4 months ago (2014-08-18 18:05:35 UTC) #4
mtklein
On 2014/08/18 18:05:35, Hal Canary wrote: > On 2014/08/18 17:10:50, mtklein wrote: > > > ...
6 years, 4 months ago (2014-08-18 18:12:26 UTC) #5
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-18 19:56:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/481053002/1
6 years, 4 months ago (2014-08-18 19:57:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (1) as 2a51d7c74cec217195f861677de8998b382b39e4
6 years, 4 months ago (2014-08-18 20:05:04 UTC) #8
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-19 13:21:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/481053002/20001
6 years, 4 months ago (2014-08-19 13:21:40 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 13:27:58 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 97d2c0a216e8feae251a6af1e50579df3e026434

Powered by Google App Engine
This is Rietveld 408576698