Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1902)

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 48103003: Enable Google Now on trybots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cosmetics Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/component_loader.cc
diff --git a/chrome/browser/extensions/component_loader.cc b/chrome/browser/extensions/component_loader.cc
index d8f0a840910c72136c9483a6f10c6a1557c3ab81..6463c296b44015ad244303cd3a73ffc25a548a33 100644
--- a/chrome/browser/extensions/component_loader.cc
+++ b/chrome/browser/extensions/component_loader.cc
@@ -521,6 +521,9 @@ void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages(
enable_prefix.length(),
enable_prefix) == 0;
+ bool is_on_unknown_channel = chrome::VersionInfo::GetChannel() ==
+ chrome::VersionInfo::CHANNEL_UNKNOWN;
+
bool enabled_via_flag =
chrome::VersionInfo::GetChannel() !=
chrome::VersionInfo::CHANNEL_STABLE &&
@@ -531,7 +534,11 @@ void ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages(
CommandLine::ForCurrentProcess()->HasSwitch(
switches::kDisableGoogleNowIntegration);
- if ((enabled_via_field_trial && !disabled_via_flag) || enabled_via_flag) {
+ bool enabled_via_field_trial_or_on_unknown_channel =
Alexei Svitkine (slow) 2013/11/01 17:56:01 Nit: move this right below |is_on_unknown_channel|
vadimt 2013/11/01 18:03:51 Done.
+ enabled_via_field_trial || is_on_unknown_channel;
+
+ if ((enabled_via_field_trial_or_on_unknown_channel && !disabled_via_flag) ||
+ enabled_via_flag) {
Add(IDR_GOOGLE_NOW_MANIFEST,
base::FilePath(FILE_PATH_LITERAL("google_now")));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698