Enable Google Now on trybots

chrome/browser/extensions/component_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/component_loader.h"
 
 #include <map>
 #include <string>
 
 #include "base/command_line.h"
@@ skipping 496 matching lines @@
         base::FilePath(extension_misc::kChromeVoxExtensionPath);
     Add(IDR_CHROMEVOX_MANIFEST, path);
   }
 #endif  // defined(OS_CHROMEOS)
 
 #if defined(ENABLE_GOOGLE_NOW)
   const char kEnablePrefix[] = "Enable";
   const char kFieldTrialName[] = "GoogleNow";
   std::string enable_prefix(kEnablePrefix);
   std::string field_trial_result =
       base::FieldTrialList::FindFullName(kFieldTrialName);

[Alexei Svitkine (slow), 2013/11/01 15:16:37]

It seems this logic is also duplicated in geolocation_options_handler.cc.

Can you refactor this to a single function that both places call, so that they
don't diverge?

[vadimt, 2013/11/01 17:48:19]

In geolocation, the code is pretty dead, and that flag is never shown. We are
experimenting now with NOT providing geolocation from the client, if this
succeeds, we'll delete that code. If succeeds, we'll revive that code, and do
the unification.

 
-  bool enabled_via_field_trial = field_trial_result.compare(
-      0,
-      enable_prefix.length(),
-      enable_prefix) == 0;
+  bool enabled_via_field_trial =
+      field_trial_result.empty() ||

[Alexei Svitkine (slow), 2013/11/01 15:16:37]

Not convinced this is a good solution - for example field trial information is
not available on first run.

Another possibility is to have a client-configured field trial that will be
overridden by the server config, e.g. using
FieldTrialList::FactoryGetFieldTrial().

If you do this, how I imagine it will work:

trial = FieldTrialList::FactoryGetFieldTrial("GoogleNow", ...);
if (stable || beta)
  trial->AppendGroup("Enable", 0);
else
  trial->AppendGroup("Enable", 100);
std::string field_trial_result = trail->group_name();

How it will work is that in absence of the config, it will enable the feature
except on beta and stable platforms, and disable otherwise.

However, if there is a server-side config, the percentages specified by the
client code will be overridden by the server config. So it's still possible to
enable it on beta or stable server-side.

You can also make it so that the 100% enable is only applied when current
channel is UNKNOWN - which I think is what our bots run. That way, you'll get
coverage on the bots but not for real users (on real channels) until you enable
the server config.

[vadimt, 2013/11/01 17:48:19]

Done. I chose the second approach, since this is the minimum that we need.
GN will be enabled (unless disabled via flags):
1. On trybots (I've verified that they run on "unknown" channel.
2. For Chromium users, which is good in terms of making them run this code too.

For Canary and up it's still disabled by default.

+      field_trial_result.compare(
+          0,
+          enable_prefix.length(),
+          enable_prefix) == 0;
 
   bool enabled_via_flag =
       chrome::VersionInfo::GetChannel() !=
           chrome::VersionInfo::CHANNEL_STABLE &&
       CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableGoogleNowIntegration);
 
   bool disabled_via_flag =
       CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kDisableGoogleNowIntegration);
 
   if ((enabled_via_field_trial && !disabled_via_flag) || enabled_via_flag) {
     Add(IDR_GOOGLE_NOW_MANIFEST,
         base::FilePath(FILE_PATH_LITERAL("google_now")));
   }
 #endif
 }
 
 void ComponentLoader::UnloadComponent(ComponentExtensionInfo* component) {
   delete component->manifest;
   if (extension_service_->is_ready()) {
     extension_service_->
         RemoveComponentExtension(component->extension_id);
   }
 }
 
 }  // namespace extensions