Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 481003002: Introduce WebViewGuestDelegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2_extensions_render_frame_observer
Patch Set: Fix zoom test failure. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..202adcac9f514c3562244f4711101d7db1f59edf
--- /dev/null
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc
@@ -0,0 +1,201 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+
+#include "chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h"
+
+#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
+#include "chrome/browser/favicon/favicon_tab_helper.h"
+#include "chrome/browser/guest_view/web_view/web_view_constants.h"
+#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
+#include "chrome/browser/ui/pdf/pdf_tab_helper.h"
+#include "chrome/browser/ui/zoom/zoom_controller.h"
+#include "chrome/common/chrome_version_info.h"
+#include "components/renderer_context_menu/context_menu_delegate.h"
+#include "content/public/common/page_zoom.h"
+
+#if defined(ENABLE_PRINTING)
+#if defined(ENABLE_FULL_PRINTING)
+#include "chrome/browser/printing/print_preview_message_handler.h"
+#include "chrome/browser/printing/print_view_manager.h"
+#else
+#include "chrome/browser/printing/print_view_manager_basic.h"
+#endif // defined(ENABLE_FULL_PRINTING)
+#endif // defined(ENABLE_PRINTING)
+
+ChromeWebViewGuestDelegate::ChromeWebViewGuestDelegate(
+ extensions::WebViewGuest* web_view_guest)
+ : WebViewGuestDelegate(),
+ pending_context_menu_request_id_(0),
+ chromevox_injected_(false),
+ current_zoom_factor_(1.0),
+ web_view_guest_(web_view_guest) {
+}
+
+ChromeWebViewGuestDelegate::~ChromeWebViewGuestDelegate() {
+}
+
+double ChromeWebViewGuestDelegate::GetZoom() {
+ return current_zoom_factor_;
+}
+
+void ChromeWebViewGuestDelegate::InjectChromeVoxIfNeeded(
+ content::RenderViewHost* render_view_host) {
+#if defined(OS_CHROMEOS)
+ if (!chromevox_injected_) {
+ chromeos::AccessibilityManager* manager =
+ chromeos::AccessibilityManager::Get();
+ if (manager && manager->IsSpokenFeedbackEnabled()) {
+ manager->InjectChromeVox(render_view_host);
+ chromevox_injected_ = true;
+ }
+ }
+#endif
+}
+
+// TODO(hanxi) Investigate which of these observers should move to the
+// extension module in the future.
+void ChromeWebViewGuestDelegate::OnAttachWebViewHelpers(
+ content::WebContents* contents) {
+ // Create a zoom controller for the guest contents give it access to
+ // GetZoomLevel() and and SetZoomLevel() in WebViewGuest.
+ // TODO(wjmaclean) This currently uses the same HostZoomMap as the browser
+ // context, but we eventually want to isolate the guest contents from zoom
+ // changes outside the guest (e.g. in the main browser), so we should
+ // create a separate HostZoomMap for the guest.
+ ZoomController::CreateForWebContents(contents);
+
+ FaviconTabHelper::CreateForWebContents(contents);
+ extensions::ChromeExtensionWebContentsObserver::
+ CreateForWebContents(contents);
+#if defined(ENABLE_PRINTING)
+#if defined(ENABLE_FULL_PRINTING)
+ printing::PrintViewManager::CreateForWebContents(contents);
+ printing::PrintPreviewMessageHandler::CreateForWebContents(contents);
+#else
+ printing::PrintViewManagerBasic::CreateForWebContents(contents);
+#endif // defined(ENABLE_FULL_PRINTING)
+#endif // defined(ENABLE_PRINTING)
+ PDFTabHelper::CreateForWebContents(contents);
+}
+
+void ChromeWebViewGuestDelegate::OnDidCommitProvisionalLoadForFrame(
+ bool is_main_frame) {
+ // Update the current zoom factor for the new page.
+ ZoomController* zoom_controller =
+ ZoomController::FromWebContents(guest_web_contents());
+ DCHECK(zoom_controller);
+ current_zoom_factor_ = zoom_controller->GetZoomLevel();
+ if (is_main_frame)
+ chromevox_injected_ = false;
+}
+
+void ChromeWebViewGuestDelegate::OnDidInitialize() {
+#if defined(OS_CHROMEOS)
+ chromeos::AccessibilityManager* accessibility_manager =
+ chromeos::AccessibilityManager::Get();
+ CHECK(accessibility_manager);
+ accessibility_subscription_ = accessibility_manager->RegisterCallback(
+ base::Bind(&ChromeWebViewGuestDelegate::OnAccessibilityStatusChanged,
+ base::Unretained(this)));
+#endif
+}
+
+void ChromeWebViewGuestDelegate::OnGuestDestroyed() {
+ // Clean up custom context menu items for this guest.
+ extensions::MenuManager* menu_manager = extensions::MenuManager::Get(
+ Profile::FromBrowserContext(web_view_guest_->browser_context()));
+ menu_manager->RemoveAllContextItems(extensions::MenuItem::ExtensionKey(
+ web_view_guest_->embedder_extension_id(),
+ web_view_guest_->view_instance_id()));
+}
+
+// static
+scoped_ptr<base::ListValue> ChromeWebViewGuestDelegate::MenuModelToValue(
+ const ui::SimpleMenuModel& menu_model) {
+ scoped_ptr<base::ListValue> items(new base::ListValue());
+ for (int i = 0; i < menu_model.GetItemCount(); ++i) {
+ base::DictionaryValue* item_value = new base::DictionaryValue();
+ // TODO(lazyboy): We need to expose some kind of enum equivalent of
+ // |command_id| instead of plain integers.
+ item_value->SetInteger(webview::kMenuItemCommandId,
+ menu_model.GetCommandIdAt(i));
+ item_value->SetString(webview::kMenuItemLabel, menu_model.GetLabelAt(i));
+ items->Append(item_value);
+ }
+ return items.Pass();
+}
+
+extensions::GuestViewBase::Event* ChromeWebViewGuestDelegate::
+ OnHandleContextMenu(const content::ContextMenuParams& params) {
Fady Samuel 2014/08/20 14:45:09 HandleContextMenu
Xi Han 2014/08/20 15:46:01 Done.
+ ContextMenuDelegate* menu_delegate =
+ ContextMenuDelegate::FromWebContents(guest_web_contents());
+ DCHECK(menu_delegate);
+
+ pending_menu_ = menu_delegate->BuildMenu(guest_web_contents(), params);
+
+ // Pass it to embedder.
+ int request_id = ++pending_context_menu_request_id_;
+ scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
+ scoped_ptr<base::ListValue> items =
+ MenuModelToValue(pending_menu_->menu_model());
+ args->Set(webview::kContextMenuItems, items.release());
+ args->SetInteger(webview::kRequestId, request_id);
+ return new extensions::GuestViewBase::Event(
+ webview::kEventContextMenu, args.Pass());
+}
+
+extensions::GuestViewBase::Event* ChromeWebViewGuestDelegate::OnSetZoom(
+ double zoom_factor,
+ const std::string& old_zoom_factor,
+ const std::string& new_zoom_factor,
+ const std::string& event_zoom_change) {
Fady Samuel 2014/08/20 14:45:09 This seems weird to me. Extensions shouldn't know
Xi Han 2014/08/20 15:46:01 Done.
+ ZoomController* zoom_controller =
+ ZoomController::FromWebContents(guest_web_contents());
+ DCHECK(zoom_controller);
+ double zoom_level = content::ZoomFactorToZoomLevel(zoom_factor);
+ zoom_controller->SetZoomLevel(zoom_level);
+
+ scoped_ptr<base::DictionaryValue> args(new base::DictionaryValue());
+ args->SetDouble(old_zoom_factor, current_zoom_factor_);
+ args->SetDouble(new_zoom_factor, zoom_factor);
+ return new extensions::GuestViewBase::Event(event_zoom_change, args.Pass());
+}
+
+void ChromeWebViewGuestDelegate::SetCurrentZoomFactor(double zoom_factor) {
+ current_zoom_factor_ = zoom_factor;
+}
+
+void ChromeWebViewGuestDelegate::OnShowContextMenu(
+ int request_id,
+ const MenuItemVector* items) {
+ if (!pending_menu_.get())
+ return;
+
+ // Make sure this was the correct request.
+ if (request_id != pending_context_menu_request_id_)
+ return;
+
+ // TODO(lazyboy): Implement.
+ DCHECK(!items);
+
+ ContextMenuDelegate* menu_delegate =
+ ContextMenuDelegate::FromWebContents(guest_web_contents());
+ menu_delegate->ShowMenu(pending_menu_.Pass());
+}
+
+#if defined(OS_CHROMEOS)
+void ChromeWebViewGuestDelegate::OnAccessibilityStatusChanged(
+ const chromeos::AccessibilityStatusEventDetails& details) {
+ if (details.notification_type == chromeos::ACCESSIBILITY_MANAGER_SHUTDOWN) {
+ accessibility_subscription_.reset();
+ } else if (details.notification_type ==
+ chromeos::ACCESSIBILITY_TOGGLE_SPOKEN_FEEDBACK) {
+ if (details.enabled)
+ InjectChromeVoxIfNeeded(guest_web_contents()->GetRenderViewHost());
+ else
+ chromevox_injected_ = false;
+ }
+}
+#endif

Powered by Google App Engine
This is Rietveld 408576698