chrome/browser/resources/options/import_data_overlay.js - Issue 480953002: Implement "Autofill form data" import for Firefox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/import_data_overlay.js

Issue 480953002: Implement "Autofill form data" import for Firefox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated test case and binary file Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/importer/firefox_importer_browsertest.cc ('K') | « chrome/browser/resources/options/import_data_overlay.html ('k') | chrome/browser/ui/browser_ui_prefs.cc » ('j') | chrome/common/pref_names.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/import_data_overlay.js

diff --git a/chrome/browser/resources/options/import_data_overlay.js b/chrome/browser/resources/options/import_data_overlay.js

index 3afca328f4a714818ae0de16037092f0a8fbda35..4f40707a38f6f3782840aa35124ce1bee66874e2 100644

--- a/chrome/browser/resources/options/import_data_overlay.js

+++ b/chrome/browser/resources/options/import_data_overlay.js

@@ -49,7 +49,8 @@ cr.define('options', function() {

String($('import-history').checked),

String($('import-favorites').checked),

String($('import-passwords').checked),

- String($('import-search').checked)]);

+ String($('import-search').checked),

+ String($('import-autofill-form-data').checked)]);

};

$('import-data-cancel').onclick = function() {

@@ -75,7 +76,8 @@ cr.define('options', function() {

validateCommitButton_: function() {

var somethingToImport =

$('import-history').checked || $('import-favorites').checked ||

- $('import-passwords').checked || $('import-search').checked;

+ $('import-passwords').checked || $('import-search').checked ||

+ $('import-autofill-form-data').checked;

$('import-data-commit').disabled = !somethingToImport;

$('import-choose-file').disabled = !$('import-favorites').checked;

@@ -120,7 +122,11 @@ cr.define('options', function() {

var browserProfile;

if (this.browserProfiles.length > index)

browserProfile = this.browserProfiles[index];

- var importOptions = ['history', 'favorites', 'passwords', 'search'];

+ var importOptions = ['history',

+ 'favorites',

+ 'passwords',

+ 'search',

+ 'autofill-form-data'];

for (var i = 0; i < importOptions.length; i++) {

var checkbox = $('import-' + importOptions[i]);

var enable = browserProfile && browserProfile[importOptions[i]];

@@ -186,7 +192,8 @@ cr.define('options', function() {

var importPrefs = ['import_history',

'import_bookmarks',

'import_saved_passwords',

- 'import_search_engine'];

+ 'import_search_engine',

+ 'import_autofill_form_data'];

for (var i = 0; i < importPrefs.length; i++)

Preferences.clearPref(importPrefs[i], true);