components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc - Issue 480953002: Implement "Autofill form data" import for Firefox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc

Issue 480953002: Implement "Autofill form data" import for Firefox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback (simplify Read method) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h ('k') | components/autofill/core/browser/webdata/autofill_webdata_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc

diff --git a/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc b/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc

index ad6c132a148410b6c4594658aa7d1885f0de357d..5b645793035bafb7d2e45ac566402de0062d4723 100644

--- a/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc

+++ b/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc

@@ -245,6 +245,17 @@ scoped_ptr<WDTypedResult> AutofillWebDataBackendImpl::GetAutofillProfiles(

base::Unretained(this))));

}

+WebDatabase::State AutofillWebDataBackendImpl::UpdateAutofillEntries(

+ const std::vector<autofill::AutofillEntry>& autofill_entries,

+ WebDatabase* db) {

+ DCHECK(db_thread_->BelongsToCurrentThread());

+ if (!AutofillTable::FromWebDatabase(db)

+ ->UpdateAutofillEntries(autofill_entries))

+ return WebDatabase::COMMIT_NOT_NEEDED;

+ return WebDatabase::COMMIT_NEEDED;

WebDatabase::State AutofillWebDataBackendImpl::AddCreditCard(

const CreditCard& credit_card, WebDatabase* db) {

DCHECK(db_thread_->BelongsToCurrentThread());