Implement "Autofill form data" import for Firefox

chrome/utility/importer/firefox_importer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/importer/firefox_importer.h"
 
 #include <set>
 
 #include "base/file_util.h"
 #include "base/files/file_enumerator.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/importer/firefox_importer_utils.h"
 #include "chrome/common/importer/firefox_importer_utils.h"
 #include "chrome/common/importer/imported_bookmark_entry.h"
 #include "chrome/common/importer/imported_favicon_usage.h"
+#include "chrome/common/importer/importer_autofill_form_data_entry.h"
 #include "chrome/common/importer/importer_bridge.h"
 #include "chrome/common/importer/importer_url_row.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/utility/importer/bookmark_html_reader.h"
 #include "chrome/utility/importer/favicon_reencode.h"
 #include "chrome/utility/importer/nss_decryptor.h"
 #include "components/autofill/core/common/password_form.h"
 #include "sql/connection.h"
 #include "sql/statement.h"
 #include "url/gurl.h"
@@ skipping 102 matching lines @@
   if ((items & importer::SEARCH_ENGINES) && !cancelled()) {
     bridge_->NotifyItemStarted(importer::SEARCH_ENGINES);
     ImportSearchEngines();
     bridge_->NotifyItemEnded(importer::SEARCH_ENGINES);
   }
   if ((items & importer::PASSWORDS) && !cancelled()) {
     bridge_->NotifyItemStarted(importer::PASSWORDS);
     ImportPasswords();
     bridge_->NotifyItemEnded(importer::PASSWORDS);
   }
+  if ((items & importer::AUTOFILL_FORM_DATA) && !cancelled()) {
+    bridge_->NotifyItemStarted(importer::AUTOFILL_FORM_DATA);
+    ImportAutofillFormData();
+    bridge_->NotifyItemEnded(importer::AUTOFILL_FORM_DATA);
+  }
   bridge_->NotifyEnded();
 }
 
 void FirefoxImporter::ImportHistory() {
   base::FilePath file = source_path_.AppendASCII("places.sqlite");
   if (!base::PathExists(file))
     return;
 
   sql::Connection db;
   if (!db.Open(file))
@@ skipping 222 matching lines @@
   bridge_->SetFirefoxSearchEnginesXMLData(search_engine_data);
 }
 
 void FirefoxImporter::ImportHomepage() {
   GURL home_page = GetHomepage(source_path_);
   if (home_page.is_valid() && !IsDefaultHomepage(home_page, app_path_)) {
     bridge_->AddHomePage(home_page);
   }
 }
 
+void FirefoxImporter::ImportAutofillFormData() {
+  base::FilePath file = source_path_.AppendASCII("formhistory.sqlite");
+  if (!base::PathExists(file))
+    return;
+
+  sql::Connection db;
+  if (!db.Open(file))
+    return;
+
+  const char* query =

[Ilya Sherman, 2014/08/20 05:47:42]

nit: "const char query[] =" is more const (both the characters and the pointer
are const), and slightly more efficient.

[Nikhil, 2014/08/20 11:29:18]

Changes done for this. But there are other queries in this file which could also
use similar change (follow-up patch?).

[Ilya Sherman, 2014/08/20 20:47:22]

Yes, this would be great to fix in a follow-up patch.  Thanks!

[Nikhil, 2014/08/21 07:35:36]

Acknowledged.

+      "SELECT fieldname, value, timesUsed, firstUsed, lastUsed FROM "
+      "moz_formhistory";
+
+  sql::Statement s(db.GetUniqueStatement(query));
+
+  std::vector<ImporterAutofillFormDataEntry> form_entries;
+  while (s.Step() && !cancelled()) {
+    ImporterAutofillFormDataEntry form_entry;
+    form_entry.name = s.ColumnString16(0);
+    form_entry.value = s.ColumnString16(1);
+    form_entry.times_used = s.ColumnInt(2);
+    form_entry.first_used = base::Time::FromTimeT(s.ColumnInt64(3) / 1000000);
+    form_entry.last_used = base::Time::FromTimeT(s.ColumnInt64(4) / 1000000);
+
+    // Don't import search bar history.
+    if (base::UTF16ToUTF8(form_entry.name) == "searchbar-history")
+      continue;
+
+    form_entries.push_back(form_entry);
+  }
+
+  if (!form_entries.empty() && !cancelled())
+    bridge_->SetAutofillFormData(form_entries);
+}
+
 void FirefoxImporter::GetSearchEnginesXMLData(
     std::vector<std::string>* search_engine_data) {
   base::FilePath file = source_path_.AppendASCII("search.sqlite");
   if (!base::PathExists(file)) {
     // Since Firefox 3.5, search engines are no longer stored in search.sqlite.
     // Instead, search.json is used for storing search engines.
     GetSearchEnginesXMLDataFromJSON(search_engine_data);
     return;
   }
 
@@ skipping 330 matching lines @@
 
       if (!importer::ReencodeFavicon(&data[0], data.size(), &usage.png_data))
         continue;  // Unable to decode.
 
       usage.urls = i->second;
       favicons->push_back(usage);
     }
     s.Reset(true);
   }
 }