Implement "Autofill form data" import for Firefox

chrome/utility/importer/external_process_importer_bridge.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/utility/importer/external_process_importer_bridge.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task_runner.h"
 #include "base/values.h"
 #include "chrome/common/importer/imported_bookmark_entry.h"
 #include "chrome/common/importer/imported_favicon_usage.h"
 #include "chrome/common/importer/importer_data_types.h"
 #include "chrome/common/importer/profile_import_process_messages.h"
 #include "components/autofill/core/common/password_form.h"
 #include "ipc/ipc_sender.h"
 
 namespace {
 
 // Rather than sending all import items over IPC at once we chunk them into
 // separate requests.  This avoids the case of a large import causing
 // oversized IPC messages.
 const int kNumBookmarksToSend = 100;
 const int kNumHistoryRowsToSend = 100;
 const int kNumFaviconsToSend = 100;
-
+const int kNumAutofillFormDataToSend = 100;

[Ilya Sherman, 2014/08/20 05:47:42]

nit: Perhaps it's appropriate to reduce these four constants down to a single
one, since they are all equal?

[Ilya Sherman, 2014/08/20 05:47:42]

nit: Please leave a blank line after this one.

[Nikhil, 2014/08/20 11:29:18]

Done.

[Nikhil, 2014/08/20 11:29:18]

Hmm, they all use different structures and have different memory requirements.
Not sure whether all these constants should be equal ideally.

Anyways, if you think these four constants should be reduced to one, then let me
know and I'll update this (maybe in follow-up CL?).

 }
 
 ExternalProcessImporterBridge::ExternalProcessImporterBridge(
     const base::DictionaryValue& localized_strings,
     IPC::Sender* sender,
     base::TaskRunner* task_runner)
     : sender_(sender),
       task_runner_(task_runner) {
   // Bridge needs to make its own copy because OS 10.6 autoreleases the
   // localized_strings value that is passed in (see http://crbug.com/46003 ).
@@ skipping 95 matching lines @@
     const std::vector<std::string>& search_engine_data) {
   Send(new ProfileImportProcessHostMsg_NotifyFirefoxSearchEngData(
       search_engine_data));
 }
 
 void ExternalProcessImporterBridge::SetPasswordForm(
     const autofill::PasswordForm& form) {
   Send(new ProfileImportProcessHostMsg_NotifyPasswordFormReady(form));
 }
 
+void ExternalProcessImporterBridge::SetAutofillFormData(
+    const std::vector<ImporterAutofillFormDataEntry>& entries) {
+  Send(new ProfileImportProcessHostMsg_AutofillFormDataImportStart(
+      entries.size()));
+
+  // |autofill_form_data_entries_left| is required for the checks below as
+  // Windows has a Debug bounds-check which prevents pushing an iterator beyond
+  // its end() (i.e., |it + 2 < s.end()| crashes in debug mode if |i + 1 ==
+  // s.end()|).
+  int autofill_form_data_entries_left = entries.end() - entries.begin();
+  for (std::vector<ImporterAutofillFormDataEntry>::const_iterator it =
+           entries.begin();
+       it < entries.end();) {
+    std::vector<ImporterAutofillFormDataEntry> autofill_form_data_entry_group;
+    std::vector<ImporterAutofillFormDataEntry>::const_iterator end_group =
+        it +
+        std::min(autofill_form_data_entries_left, kNumAutofillFormDataToSend);
+    autofill_form_data_entry_group.assign(it, end_group);
+
+    Send(new ProfileImportProcessHostMsg_AutofillFormDataImportGroup(
+        autofill_form_data_entry_group));
+    autofill_form_data_entries_left -= end_group - it;
+    it = end_group;
+  }
+  DCHECK_EQ(0, autofill_form_data_entries_left);
+}
+
 void ExternalProcessImporterBridge::NotifyStarted() {
   Send(new ProfileImportProcessHostMsg_Import_Started());
 }
 
 void ExternalProcessImporterBridge::NotifyItemStarted(
     importer::ImportItem item) {
   Send(new ProfileImportProcessHostMsg_ImportItem_Started(item));
 }
 
 void ExternalProcessImporterBridge::NotifyItemEnded(importer::ImportItem item) {
@@ skipping 17 matching lines @@
   task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&ExternalProcessImporterBridge::SendInternal,
                  this, message));
 }
 
 void ExternalProcessImporterBridge::SendInternal(IPC::Message* message) {
   DCHECK(task_runner_->RunsTasksOnCurrentThread());
   sender_->Send(message);
 }