Implement "Autofill form data" import for Firefox

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
 namespace prefs {
@@ skipping 1116 matching lines @@
 const char kImportHomepage[] = "import_home_page";
 
 // Boolean that specifies whether to import the search engine from the default
 // browser on first run.
 const char kImportSearchEngine[] = "import_search_engine";
 
 // Boolean that specifies whether to import the saved passwords from the default
 // browser on first run.
 const char kImportSavedPasswords[] = "import_saved_passwords";
 
+// Boolean that specifies whether to import the form data for autofill from the
+// default browser on first run.
+const char kImportAutofillFormData[] = "import_autofill_form_data";

[Ilya Sherman, 2014/08/20 05:47:41]

Hmm, does this only affect first-run?  Is there any reason that we'd ever want
to automatically import form data on the first run?  That seems pretty
heavy-handed to me... though maybe that's consistent with how we import on first
run in general.

[Nikhil, 2014/08/20 11:29:17]

I think this is only for registering preferences with user profile. As I
understand, this preference is used in import_data_overlay.html.

One place that I seem to have missed (on account of consistency) adding
kImportAutofillFormData is configuration_policy_handler_list_factory.cc.
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pol...

Shall I add there also? 

[Ilya Sherman, 2014/08/20 20:47:22]

If that's so, then let's update the comment for this preference.
Yeah, probably a good idea.  I'm not too familiar with the enterprise policy
code, though.

[Nikhil, 2014/08/21 07:35:36]

[1] Feature works fine even if we remove this pref. This pref is not really used
in importer logic. But UI uses this exact string and sets it in pref property
(import_data_overlay.html). So, I think it might be okay to keep this preference
and set it in user pref to keep things consistent.

[2] First run, indeed, uses these preferences to decide whether to import or not
based on master preference (not sure what this is) and profile preference. But I
think additional logic is required to handle autofill form data (if we do want
to import it on first run). Also, I think current first run import logic doesn't
import saved passwords. See
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/fir...
Me neither. Anyhow, I tried to modify it but it didn't compile. Generated file
policy_constants.h didn't have kImportAutofillFormData . I'm guessing this is
something to do with Enterprise policy but I'm not sure if we need this change.

+
 // Profile avatar and name
 const char kProfileAvatarIndex[] = "profile.avatar_index";
 const char kProfileName[] = "profile.name";
 // Whether a profile is using a default avatar name (eg. Pickles or Person 1)
 // because it was randomly assigned at profile creation time.
 const char kProfileUsingDefaultName[] = "profile.using_default_name";
 // Whether a profile is using an avatar without having explicitely chosen it
 // (i.e. was assigned by default by legacy profile creation).
 const char kProfileUsingDefaultAvatar[] = "profile.using_default_avatar";
 const char kProfileUsingGAIAAvatar[] = "profile.using_gaia_avatar";
@@ skipping 1189 matching lines @@
 const char kPartnerBookmarkMappings[] = "partnerbookmarks.mappings";
 #endif
 
 // Whether DNS Quick Check is disabled in proxy resolution.
 const char kQuickCheckEnabled[] = "proxy.quick_check_enabled";
 
 // Whether Guest Mode is enabled within the browser.
 const char kBrowserGuestModeEnabled[] = "profile.browser_guest_enabled";
 
 }  // namespace prefs