Implement "Autofill form data" import for Firefox

chrome/browser/importer/firefox_importer_browsertest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/stl_util.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/importer/external_process_importer_host.h"
 #include "chrome/browser/importer/importer_progress_observer.h"
 #include "chrome/browser/importer/importer_unittest_utils.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/importer/imported_bookmark_entry.h"
 #include "chrome/common/importer/imported_favicon_usage.h"
 #include "chrome/common/importer/importer_data_types.h"
 #include "chrome/test/base/in_process_browser_test.h"
+#include "components/autofill/core/browser/webdata/autofill_entry.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/search_engines/template_url.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // TODO(estade): some of these are disabled on mac. http://crbug.com/48007
 // TODO(jschuh): Disabled on Win64 build. http://crbug.com/179688
 #if defined(OS_MACOSX) || (defined(OS_WIN) && defined(ARCH_CPU_X86_64))
 #define MAYBE_IMPORTER(x) DISABLED_##x
 #else
 #define MAYBE_IMPORTER(x) x
@@ skipping 11 matching lines @@
   const char* password;
   bool blacklisted;
 };
 
 struct KeywordInfo {
   const wchar_t* keyword_in_sqlite;
   const wchar_t* keyword_in_json;
   const char* url;
 };
 
+struct AutofillFormDataInfo {
+  const char* name;
+  const char* value;
+};
+
 const BookmarkInfo kFirefoxBookmarks[] = {
   {true, 1, {"Bookmarks Toolbar"},
     L"Toolbar",
     "http://site/"},
   {false, 0, {},
     L"Title",
     "http://www.google.com/"},
 };
 
 const PasswordInfo kFirefoxPasswords[] = {
@@ skipping 23 matching lines @@
      "http://search.yahoo.com/search?p={searchTerms}&ei=UTF-8"},
     {L"flickr.com", L"flickr.com",
      "http://www.flickr.com/photos/tags/?q={searchTerms}"},
     {L"imdb.com", L"imdb.com", "http://www.imdb.com/find?q={searchTerms}"},
     {L"webster.com", L"webster.com",
      "http://www.webster.com/cgi-bin/dictionary?va={searchTerms}"},
     // Search keywords.
     {L"\x4E2D\x6587", L"\x4E2D\x6587", "http://www.google.com/"},
 };
 
+const AutofillFormDataInfo kFirefoxAutofill[] = {

[Ilya Sherman, 2014/08/20 05:47:41]

nit: "kFirefoxAutofillEntries"

[Nikhil, 2014/08/20 11:29:16]

Done.

+    {"name", "user_one"},
+    {"n300", "user_two"},

[Ilya Sherman, 2014/08/20 05:47:41]

Please include additional cases: case sensitivity, unicode characters, empty
strings, and any other potential edge cases that you can think of.

[Nikhil, 2014/08/20 11:29:16]

I'm going to add these in next revision of this CL as it will take some time to
prepare binary file accordingly. Hope this is okay.

But please do take a look at other changes, and let me know your review comments
:)

+};
+
 class FirefoxObserver : public ProfileWriter,
                         public importer::ImporterProgressObserver {
  public:
   explicit FirefoxObserver(bool use_keyword_in_json)
       : ProfileWriter(NULL),
         bookmark_count_(0),
         history_count_(0),
         password_count_(0),
         keyword_count_(0),
         use_keyword_in_json_(use_keyword_in_json) {}
@@ skipping 53 matching lines @@
     // Importer should import the FF favorites the same as the list, in the same
     // order.
     for (size_t i = 0; i < bookmarks.size(); ++i) {
       EXPECT_NO_FATAL_FAILURE(
           TestEqualBookmarkEntry(bookmarks[i],
                                  kFirefoxBookmarks[bookmark_count_])) << i;
       ++bookmark_count_;
     }
   }
 
+  virtual void AddAutofillFormDataEntries(
+      const std::vector<autofill::AutofillEntry>& autofill_entries) OVERRIDE {
+    EXPECT_EQ(arraysize(kFirefoxAutofill), autofill_entries.size());
+    for (size_t i = 0; i < arraysize(kFirefoxAutofill); ++i) {
+      EXPECT_EQ(kFirefoxAutofill[i].name,
+                base::UTF16ToUTF8(autofill_entries[i].key().name()));
+      EXPECT_EQ(kFirefoxAutofill[i].value,
+                base::UTF16ToUTF8(autofill_entries[i].key().value()));
+    }
+  }
+
   virtual void AddKeywords(ScopedVector<TemplateURL> template_urls,
                            bool unique_on_host_and_path) OVERRIDE {
     for (size_t i = 0; i < template_urls.size(); ++i) {
       // The order might not be deterministic, look in the expected list for
       // that template URL.
       bool found = false;
       const base::string16& imported_keyword = template_urls[i]->keyword();
       for (size_t j = 0; j < arraysize(kFirefoxKeywords); ++j) {
         const base::string16 expected_keyword = base::WideToUTF16(
             use_keyword_in_json_ ?
@@ skipping 84 matching lines @@
     ASSERT_TRUE(base::CopyDirectory(
         custom_search_engine_source_path, custom_search_engine_path, false));
 
     importer::SourceProfile source_profile;
     source_profile.importer_type = importer::TYPE_FIREFOX;
     source_profile.app_path = app_path_;
     source_profile.source_path = profile_path_;
     source_profile.locale = "en-US";
 
     int items = importer::HISTORY | importer::PASSWORDS | importer::FAVORITES |
-                importer::SEARCH_ENGINES;
+                importer::SEARCH_ENGINES | importer::AUTOFILL_FORM_DATA;
 
     // Deletes itself.
     ExternalProcessImporterHost* host = new ExternalProcessImporterHost;
     host->set_observer(observer);
     host->StartImportSettings(
         source_profile, browser()->profile(), items, writer);
     base::MessageLoop::current()->Run();
   }
 
   base::ScopedTempDir temp_dir_;
@@ skipping 13 matching lines @@
   scoped_refptr<FirefoxObserver> observer(new FirefoxObserver(false));
   FirefoxImporterBrowserTest(
       "firefox35_profile", observer.get(), observer.get());
 }
 
 IN_PROC_BROWSER_TEST_F(FirefoxProfileImporterBrowserTest,
                        MAYBE_IMPORTER(FirefoxImporter)) {
   scoped_refptr<FirefoxObserver> observer(new FirefoxObserver(true));
   FirefoxImporterBrowserTest("firefox_profile", observer.get(), observer.get());
 }