Implement "Autofill form data" import for Firefox

chrome/common/importer/profile_import_process_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, no traditonal include guard.
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/strings/string16.h"
 #include "base/values.h"
 #include "chrome/common/common_param_traits_macros.h"
 #include "chrome/common/importer/imported_bookmark_entry.h"
 #include "chrome/common/importer/imported_favicon_usage.h"
+#include "chrome/common/importer/importer_autofill_form_data_entry.h"
 #include "chrome/common/importer/importer_data_types.h"
 #include "chrome/common/importer/importer_url_row.h"
 #include "components/autofill/content/common/autofill_param_traits_macros.h"
 #include "components/autofill/core/common/password_form.h"
 #include "content/public/common/common_param_traits.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_message_utils.h"
 
 #ifndef CHROME_COMMON_IMPORTER_PROFILE_IMPORT_PROCESS_MESSAGES_H_
 #define CHROME_COMMON_IMPORTER_PROFILE_IMPORT_PROCESS_MESSAGES_H_
@@ skipping 224 matching lines @@
   }
 };  // ParamTraits<importer::ImporterIE7PasswordInfo>
 #endif
 
 }  // namespace IPC
 
 #endif  // CHROME_COMMON_IMPORTER_PROFILE_IMPORT_PROCESS_MESSAGES_H_
 
 #define IPC_MESSAGE_START ProfileImportMsgStart
 
+IPC_STRUCT_TRAITS_BEGIN(ImporterAutofillFormDataEntry)
+  IPC_STRUCT_TRAITS_MEMBER(name)
+  IPC_STRUCT_TRAITS_MEMBER(value)
+  IPC_STRUCT_TRAITS_MEMBER(times_used)
+  IPC_STRUCT_TRAITS_MEMBER(first_used)
+  IPC_STRUCT_TRAITS_MEMBER(last_used)
+IPC_STRUCT_TRAITS_END()

[Ilya Sherman, 2014/09/02 20:22:37]

It looks like this should be defined slightly earlier in the file, possible
before line 256.

[Nikhil, 2014/09/03 04:36:27]

If I do that, then I get linker errors locally for Read and Write methods.
Please see -

error: undefined reference to
'IPC::ParamTraits<ImporterAutofillFormDataEntry>::Write(IPC::Message*,
ImporterAutofillFormDataEntry const&)'

error: undefined reference to
'IPC::ParamTraits<ImporterAutofillFormDataEntry>::Read(IPC::Message const*,
PickleIterator*, ImporterAutofillFormDataEntry*)'

How about - 

[1] Go to initial approach of packing/unpacking message without using
IPC_STRUCT_TRAITS_* macros for now. I'm guessing mac bot will compile.
(https://codereview.chromium.org/480953002/diff/20001/chrome/common/importer/p...)

[2] I update this whole file to use IPC_STRUCT_TRAITS_* macros. Similar to
print_messages.h.
(https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/prin...)

If you think doing [2] first makes more sense, then we can do that also. Please
let me know WDYT.

+
 //-----------------------------------------------------------------------------
 // ProfileImportProcess messages
 // These are messages sent from the browser to the profile import process.
 IPC_MESSAGE_CONTROL3(ProfileImportProcessMsg_StartImport,
                      importer::SourceProfile,
                      int                     /* Bitmask of items to import. */,
                      base::DictionaryValue   /* Localized strings. */)
 
 IPC_MESSAGE_CONTROL0(ProfileImportProcessMsg_CancelImport)
 
@@ skipping 46 matching lines @@
 IPC_MESSAGE_CONTROL1(ProfileImportProcessHostMsg_NotifyPasswordFormReady,
                      autofill::PasswordForm)
 
 IPC_MESSAGE_CONTROL2(ProfileImportProcessHostMsg_NotifyKeywordsReady,
                      std::vector<importer::URLKeywordInfo>, // url_keywords
                      bool  /* unique on host and path */)
 
 IPC_MESSAGE_CONTROL1(ProfileImportProcessHostMsg_NotifyFirefoxSearchEngData,
                      std::vector<std::string>) // search_engine_data
 
+IPC_MESSAGE_CONTROL1(ProfileImportProcessHostMsg_AutofillFormDataImportStart,
+                     int  /* total number of entries to be imported */)
+
+IPC_MESSAGE_CONTROL1(ProfileImportProcessHostMsg_AutofillFormDataImportGroup,
+                     std::vector<ImporterAutofillFormDataEntry>)
+
 #if defined(OS_WIN)
 IPC_MESSAGE_CONTROL1(ProfileImportProcessHostMsg_NotifyIE7PasswordInfo,
                      importer::ImporterIE7PasswordInfo) // password_info
 #endif