Implement "Autofill form data" import for Firefox

chrome/browser/importer/external_process_importer_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/importer/external_process_importer_client.h"
 
 #include "base/bind.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/importer/external_process_importer_host.h"
@@ skipping 88 matching lines @@
     IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyFaviconsImportStart,
                         OnFaviconsImportStart)
     IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyFaviconsImportGroup,
                         OnFaviconsImportGroup)
     IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyPasswordFormReady,
                         OnPasswordFormImportReady)
     IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyKeywordsReady,
                         OnKeywordsImportReady)
     IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyFirefoxSearchEngData,
                         OnFirefoxSearchEngineDataReceived)
+    IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_AutofillFormDataImportStart,
+                        OnAutofillFormDataImportStart)
+    IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_AutofillFormDataImportGroup,
+                        OnAutofillFormDataImportGroup)
 #if defined(OS_WIN)
     IPC_MESSAGE_HANDLER(ProfileImportProcessHostMsg_NotifyIE7PasswordInfo,
                         OnIE7PasswordReceived)
 #endif
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void ExternalProcessImporterClient::OnImportStart() {
@@ skipping 124 matching lines @@
   bridge_->SetKeywords(url_keywords, unique_on_host_and_path);
 }
 
 void ExternalProcessImporterClient::OnFirefoxSearchEngineDataReceived(
     const std::vector<std::string> search_engine_data) {
   if (cancelled_)
     return;
   bridge_->SetFirefoxSearchEnginesXMLData(search_engine_data);
 }
 
+void ExternalProcessImporterClient::OnAutofillFormDataImportStart(
+    size_t total_autofill_form_data_entry_count) {
+  if (cancelled_)
+    return;
+
+  total_autofill_form_data_entry_count_ = total_autofill_form_data_entry_count;
+  autofill_form_data_.reserve(total_autofill_form_data_entry_count);
+}
+
+void ExternalProcessImporterClient::OnAutofillFormDataImportGroup(
+    const std::vector<ImporterAutofillFormDataEntry>&
+        autofill_form_data_entry_group) {
+  if (cancelled_)
+    return;
+
+  autofill_form_data_.insert(autofill_form_data_.end(),
+                             autofill_form_data_entry_group.begin(),
+                             autofill_form_data_entry_group.end());
+  if (autofill_form_data_.size() == total_autofill_form_data_entry_count_)

[Tom Sepez, 2014/08/27 23:10:21]

What if the import process can't count?  There's no reason to trust that it
won't give more data than previously claimed in the start message.

[Nikhil, 2014/08/28 06:54:59]

Sorry, but I don't fully understand the comment so I'm unsure about the change
required. Could you please explain a little more?

The count is actually maintained by Importer utility based on number of enteries
imported from Firefox. Enteries are sent in groups through IPC. The count of
enteris left to be sent is then updated accordingly (and same is repeated until
all enteries have been sent). Since the count is maintained consistently, I
think it is not possible to send data more than what was initially claimed in
start message.

PTAL at
https://codereview.chromium.org/480953002/diff/120001/chrome/utility/importer...

Please let me know WDYT.

[Ilya Sherman, 2014/08/30 01:30:18]

FWIW, all the other importer types use "==" as the comparison.  Perhaps it's
best to match those for now, and to file a follow-up bug to update this
comparison for all of the importer types?  Tom, WDYT?

+    bridge_->SetAutofillFormData(autofill_form_data_);
+}
+
 #if defined(OS_WIN)
 void ExternalProcessImporterClient::OnIE7PasswordReceived(
     const importer::ImporterIE7PasswordInfo& importer_password_info) {
   if (cancelled_)
     return;
   bridge_->AddIE7PasswordInfo(importer_password_info);
 }
 #endif
 
 ExternalProcessImporterClient::~ExternalProcessImporterClient() {}
@@ skipping 54 matching lines @@
   localized_strings.SetString(
       base::IntToString(IDS_IMPORT_FROM_SAFARI),
       l10n_util::GetStringUTF8(IDS_IMPORT_FROM_SAFARI));
   localized_strings.SetString(
       base::IntToString(IDS_BOOKMARK_BAR_FOLDER_NAME),
       l10n_util::GetStringUTF8(IDS_BOOKMARK_BAR_FOLDER_NAME));
 
   utility_process_host_->Send(new ProfileImportProcessMsg_StartImport(
       source_profile_, items_, localized_strings));
 }