Service Worker: Add tests for same-scope new script registration

Service Worker: Add tests for same-scope, new script registration

Tests for Chromium patch:
https://codereview.chromium.org/506043002/

BUG=398355
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180948

[nhiroki, 2014-08-21 09:26:04]

LGTM with nits.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html
(right):

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:19:
register_promise2 = navigator.serviceWorker.register(script2, {scope: scope});
nit: Can you wrap at 80-columns?

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:205:
return wait_for_state(t, installing_worker, 'activated');
nit: installing_worker -> registration.installing (for consistency with other
tests)

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:217:
.then(function(installing_worker) {
nit: 'installing_worker' is never used.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:222:
assert_equals(sw_container.controller.scriptURL, normalizeURL(script1),
nit: |script1| was already normalized at line 6.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:228:
assert_equals(sw_container.controller.scriptURL, normalizeURL(script1),
ditto (normalizeURL).

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:242:
assert_equals(sw_container.controller.scriptURL, normalizeURL(script2),
ditto (normalizeURL).

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html
(right):

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html:141:
var promise = navigator.serviceWorker.register('this-will-404', { scope: scope
});
nit: 80-columns.

[falken, 2014-08-21 09:42:57]

Thanks for the review.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html
(right):

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:19:
register_promise2 = navigator.serviceWorker.register(script2, {scope: scope});
On 2014/08/21 09:26:03, nhiroki wrote:
> nit: Can you wrap at 80-columns?

Done.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:205:
return wait_for_state(t, installing_worker, 'activated');
On 2014/08/21 09:26:03, nhiroki wrote:
> nit: installing_worker -> registration.installing (for consistency with other
> tests)

Done.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:217:
.then(function(installing_worker) {
On 2014/08/21 09:26:03, nhiroki wrote:
> nit: 'installing_worker' is never used.

Done.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:222:
assert_equals(sw_container.controller.scriptURL, normalizeURL(script1),
On 2014/08/21 09:26:03, nhiroki wrote:
> nit: |script1| was already normalized at line 6.

Good point. Done.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:228:
assert_equals(sw_container.controller.scriptURL, normalizeURL(script1),
On 2014/08/21 09:26:03, nhiroki wrote:
> ditto (normalizeURL).

Done.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:242:
assert_equals(sw_container.controller.scriptURL, normalizeURL(script2),
On 2014/08/21 09:26:03, nhiroki wrote:
> ditto (normalizeURL).

Done.

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html
(right):

https://codereview.chromium.org/480943002/diff/40001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html:141:
var promise = navigator.serviceWorker.register('this-will-404', { scope: scope
});
On 2014/08/21 09:26:04, nhiroki wrote:
> nit: 80-columns.

Done.

[michaeln, 2014-08-26 23:17:05]

lgtm, these tests are awesome!

https://codereview.chromium.org/480943002/diff/60001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html
(right):

https://codereview.chromium.org/480943002/diff/60001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:232:
var active_seen = wait_for_state(t,
nit: rename this to something c'oser to onactivated_promise? (something with
_promise on the end).

[falken, 2014-08-27 04:19:41]

Thanks!

https://codereview.chromium.org/480943002/diff/60001/LayoutTests/http/tests/s...
File
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html
(right):

https://codereview.chromium.org/480943002/diff/60001/LayoutTests/http/tests/s...
LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html:232:
var active_seen = wait_for_state(t,
On 2014/08/26 23:17:05, michaeln wrote:
> nit: rename this to something c'oser to onactivated_promise? (something with
> _promise on the end).

Agreed that was an odd name. We have "saw_xxx" in some tests. I've gone with
_promise as suggested.

[falken, 2014-08-27 07:22:58]

The CQ bit was checked by falken@chromium.org

[commit-bot: I haz the power, 2014-08-27 07:23:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/falken@chromium.org/480943002/100001

[commit-bot: I haz the power, 2014-08-27 08:25:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[commit-bot: I haz the power, 2014-08-27 08:47:01]

Committed patchset #6 (100001) as 180948

[mlamouri (slow - plz ping), 2014-08-27 10:38:32]

A revert of this CL (patchset #6) has been created in
https://codereview.chromium.org/512703002/ by mlamouri@chromium.org.

The reason for reverting is: This is crashing on Mac..