Issue 480863002: Refactor ChangeLowering class to avoid template specialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480863002: Refactor ChangeLowering class to avoid template specialization. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Refactor ChangeLowering class to avoid template specialization. Also refactor the unit tests and add support to easily match DAGs using CaptureEq() matcher. TEST=compiler-unittests BUG=v8:3489 LOG=n R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23140

Patch Set 1 #

Patch Set 2 : Fix #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+416 lines, -840 lines)			Patch
M	src/compiler/change-lowering.h	View		1 chunk	+22 lines, -46 lines	0 comments	Download
M	src/compiler/change-lowering.cc	View		5 chunks	+61 lines, -165 lines	0 comments	Download
M	src/compiler/js-graph.h	View		4 chunks	+4 lines, -1 line	0 comments	Download
M	src/compiler/js-graph.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/DEPS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/compiler-unittests/change-lowering-unittest.cc	View		9 chunks	+56 lines, -76 lines	0 comments	Download
A	test/compiler-unittests/common-operator-unittest.h	View		1 chunk	+31 lines, -0 lines	0 comments	Download
A	test/compiler-unittests/common-operator-unittest.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/compiler-unittests.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/compiler-unittests/compiler-unittests.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	test/compiler-unittests/compiler-unittests.gyp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
A +	test/compiler-unittests/graph-unittest.h	View		3 chunks	+22 lines, -6 lines	0 comments	Download
A +	test/compiler-unittests/graph-unittest.cc	View		5 chunks	+105 lines, -2 lines	0 comments	Download
M	test/compiler-unittests/machine-operator-reducer-unittest.cc	View		2 chunks	+3 lines, -12 lines	0 comments	Download
D	test/compiler-unittests/node-matchers.h	View		1 chunk	+0 lines, -73 lines	0 comments	Download
D	test/compiler-unittests/node-matchers.cc	View		1 chunk	+0 lines, -456 lines	0 comments	Download
M	testing/gmock.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
A	testing/gmock-support.h	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 4 months ago (2014-08-18 06:54:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 23140 (tree was closed).

Expand Messages | Collapse Messages