Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2313)

Issue 480793002: Set setCompositedScrollingForFramesEnabled when prefer compositing. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, abarth-chromium, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

Set setCompositedScrollingForFramesEnabled when prefer compositing. Merge setCompositedScrollingForFramesEnabled with the new setPreferCompositingToLCDTextEnabled by setting the old one to true iff we set setPreferCompositingToLCDTextEnabled to true. Then we can remove the setCompositedScrollingForFramesEnabled method. R=piman@chromium.org BUG=365851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290571

Patch Set 1 : compositedscrollingforframes: #

Patch Set 2 : compositedscrollingforframes: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M content/renderer/render_view_impl.cc View 1 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
danakj
Depends on https://codereview.chromium.org/485553002/
6 years, 4 months ago (2014-08-17 22:05:05 UTC) #1
piman
lgtm
6 years, 4 months ago (2014-08-18 17:33:22 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 21:23:21 UTC) #3
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 21:23:41 UTC) #4
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 21:24:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/480793002/1
6 years, 4 months ago (2014-08-18 21:25:43 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-18 21:30:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-18 21:32:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/4850)
6 years, 4 months ago (2014-08-18 21:32:31 UTC) #9
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 21:32:49 UTC) #10
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-18 21:46:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/480793002/20001
6 years, 4 months ago (2014-08-18 21:48:14 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-18 23:17:25 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-19 00:34:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_triggered_tests/builds/6822)
6 years, 4 months ago (2014-08-19 00:34:55 UTC) #15
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-19 14:18:04 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/480793002/20001
6 years, 4 months ago (2014-08-19 14:19:33 UTC) #17
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 16:00:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290571

Powered by Google App Engine
This is Rietveld 408576698