Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 480723006: Initialize show_on_resize_ (Closed)

Created:
6 years, 4 months ago by bshe
Modified:
6 years, 3 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Initialize show_on_resize_ Memory test failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%283%29/builds/33712 Error message: Suppression (error hash=#07239B8B18CB7B1B#): For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports { <insert_a_suppression_name_here> Memcheck:Uninitialized fun:_ZN8keyboard21KeyboardLayoutManager14SetChildBoundsEPN4aura6WindowERKN3gfx4RectE fun:_ZN4aura6Window9SetBoundsERKN3gfx4RectE fun:_ZN3ash4test71VirtualKeyboardRootWindowControllerTest_ClickWithActiveModalDialog_Test8TestBodyEv } TBR=jyasskin BUG=NONE Committed: https://crrev.com/91f2725413c17c35792d4e07b1c6f9bf75baeade Cr-Commit-Position: refs/heads/master@{#291794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/keyboard/keyboard_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bshe
bshe@chromium.org changed reviewers: + jyasskin@chromium.org
6 years, 4 months ago (2014-08-25 19:00:58 UTC) #1
bshe
Hi Jeffrey Looks like you are memory sherrif today. My CL: https://codereview.chromium.org/487253003 breaks Chromium OS ...
6 years, 4 months ago (2014-08-25 19:00:59 UTC) #2
bshe
bshe@chromium.org changed reviewers: - jyasskin@chromium.org
6 years, 3 months ago (2014-08-25 21:48:22 UTC) #3
bshe
On 2014/08/25 21:48:22, bshe wrote: > mailto:bshe@chromium.org changed reviewers: > - mailto:jyasskin@chromium.org Switch to TBR ...
6 years, 3 months ago (2014-08-25 21:49:38 UTC) #4
bshe
The CQ bit was checked by bshe@chromium.org
6 years, 3 months ago (2014-08-25 21:49:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bshe@chromium.org/480723006/1
6 years, 3 months ago (2014-08-25 21:51:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (1) as 151694ca1f77dcd7eb609ad975d526cf3e8a109a
6 years, 3 months ago (2014-08-25 23:58:08 UTC) #7
Jeffrey Yasskin
jyasskin@chromium.org changed reviewers: + jyasskin@chromium.org
6 years, 3 months ago (2014-08-26 15:29:08 UTC) #8
Jeffrey Yasskin
lgtm. Sorry for missing this.
6 years, 3 months ago (2014-08-26 15:29:08 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:38:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91f2725413c17c35792d4e07b1c6f9bf75baeade
Cr-Commit-Position: refs/heads/master@{#291794}

Powered by Google App Engine
This is Rietveld 408576698