Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 480693002: Use a qualified path for ui_resources.h grit includes. (Closed)

Created:
6 years, 4 months ago by tfarina
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, alicet1, msw+watch_chromium.org, dcheng, Nico
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : ash deps #

Patch Set 6 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -129 lines) Patch
M android_webview/browser/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ash/DEPS View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ash/drag_drop/drag_image_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/hover_highlight_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_bar_button_with_title.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/accounts_detailed_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/custom_home_pages_table_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_ntp_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/browser_theme_pack.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_properties.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/android/navigation_popup.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/chrome_style.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_account_chooser.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_button_cell_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop_cocoa.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/edit_search_engine_cocoa_controller_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/history_menu_bridge.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hover_close_button.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/hung_renderer_controller.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/infobar_controller.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/sprite_view_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/favicon_util_mac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/app_list/app_list_dialog_contents_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/edit_search_engine_dialog.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/bundle_installed_bubble.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_frame_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_password_item_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/session_crashed_bubble_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_icon_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/badge_util.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/DEPS View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/aura/gesture_nav_simple.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_drag_source_mac.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/app_list_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/cocoa/apps_search_box_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/demo/app_list_demo_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/views/contents_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/progress_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/search_box_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/app_list/views/speech_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/base/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/base/cocoa/menu_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M ui/base/cursor/cursors_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/message_center/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/notification_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/settings_entry_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/status_item_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/cocoa/tray_view_controller.mm View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_button_bar.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/message_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/message_center/views/notifier_settings_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/native_theme/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/common_theme.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_base.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_border.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/button_drag_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/blue_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/checkbox.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/label_button_border.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/button/radio_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/combobox.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_config_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_image_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/throbber.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/examples/button_example.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/window/custom_frame_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/wm/core/DEPS View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/shadow.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
tfarina
6 years, 4 months ago (2014-08-16 02:50:39 UTC) #1
Lei Zhang
lgtm with a comment: https://codereview.chromium.org/480693002/diff/60001/ash/DEPS File ash/DEPS (right): https://codereview.chromium.org/480693002/diff/60001/ash/DEPS#newcode16 ash/DEPS:16: "+ui/resources/grit/ui_resources.h", do you need this ...
6 years, 4 months ago (2014-08-16 03:39:57 UTC) #2
Nico
lgtm2 Thanks!
6 years, 4 months ago (2014-08-16 04:00:32 UTC) #3
tfarina
TBRing Ben for src/ (trivial include path changes)... https://codereview.chromium.org/480693002/diff/60001/ash/DEPS File ash/DEPS (right): https://codereview.chromium.org/480693002/diff/60001/ash/DEPS#newcode16 ash/DEPS:16: "+ui/resources/grit/ui_resources.h", ...
6 years, 4 months ago (2014-08-16 23:38:24 UTC) #4
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-16 23:38:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/480693002/80001
6 years, 4 months ago (2014-08-16 23:38:59 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-16 23:52:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-16 23:54:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/6722) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/4005)
6 years, 4 months ago (2014-08-16 23:54:27 UTC) #9
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 4 months ago (2014-08-17 01:52:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/480693002/100001
6 years, 4 months ago (2014-08-17 01:52:55 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-17 06:19:07 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (100001) as 290178
6 years, 4 months ago (2014-08-17 07:06:02 UTC) #13
ismetsevinc3
On 2014/08/17 07:06:02, commit-bot: I has the power wrote: > Committed patchset #6 (100001) as ...
4 years, 3 months ago (2016-09-18 18:26:26 UTC) #14
ismetsevinc3
4 years, 3 months ago (2016-09-18 18:26:31 UTC) #15
Message was sent while issue was closed.
On 2014/08/17 07:06:02, commit-bot: I has the power wrote:
> Committed patchset #6 (100001) as 290178
Follow Me on instagram: İzzeee_ones

Powered by Google App Engine
This is Rietveld 408576698