Issue 480683003: [SyncFS] Fix error of handling demoted dirty trackers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 480683003: [SyncFS] Fix error of handling demoted dirty trackers (Closed)

Created:
6 years, 4 months ago by peria

Modified:
6 years, 3 months ago

Reviewers:
nhiroki, tzik

CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[SyncFS] Fix error of handling demoted dirty trackers PromoteDemotedDirtyTrackers() confused demoted dirty trackers and non-demoted dirty trackers. BUG=None TEST=./unit_tests --gtest_filter="MetadataDatabaseIndex*" Committed: https://crrev.com/5e4eefdecbd95539899f2a060c27b802466f5182 Cr-Commit-Position: refs/heads/master@{#291651}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/480683003/1

6 years, 4 months ago (2014-08-25 07:31:02 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as 394030c10f9d4b96ecb67bf5078e6c29aca0c95c

6 years, 4 months ago (2014-08-25 08:24:50 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:33:24 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5e4eefdecbd95539899f2a060c27b802466f5182
Cr-Commit-Position: refs/heads/master@{#291651}

Expand Messages | Collapse Messages