Issue 48068: Cleanup GTK toolbar tooltips. Move from GtkTooltips to GtkTooltip API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48068: Cleanup GTK toolbar tooltips. Move from GtkTooltips to GtkTooltip API. (Closed)

Created:
11 years, 9 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
tony, Elliot Glaysher, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Cleanup GTK toolbar tooltips. Move from GtkTooltips to GtkTooltip API. Move away from the deprecated GtkTooltips API, instead using the preferred methods on GtkWidget. Add missing tooltips to the back and forward buttons. This also fixes a memory leak of the old tooltips object which is no longer needed. BUG=8868

Patch Set 1 #

Patch Set 2 : Diff from correct branch #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -17 lines)			Patch
	M	chrome/browser/gtk/browser_toolbar_gtk.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	chrome/browser/gtk/browser_toolbar_gtk.cc	View	1	4 chunks	+6 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages