Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Unified Diff: mojo/public/cpp/bindings/lib/connector.cc

Issue 480663003: Converts some DCHECKs into CHECKs in hopes of helping with a crash (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/lib/interface_impl_internal.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/lib/connector.cc
diff --git a/mojo/public/cpp/bindings/lib/connector.cc b/mojo/public/cpp/bindings/lib/connector.cc
index 6665ff9442a1d078d3554358215ff5a4c424cb4f..af73008a9beab0b01e6977b9158c10be70e78271 100644
--- a/mojo/public/cpp/bindings/lib/connector.cc
+++ b/mojo/public/cpp/bindings/lib/connector.cc
@@ -63,7 +63,7 @@ bool Connector::WaitForIncomingMessage() {
}
bool Connector::Accept(Message* message) {
- MOJO_DCHECK(message_pipe_.is_valid());
+ MOJO_CHECK(message_pipe_.is_valid());
if (error_)
return false;
@@ -122,7 +122,7 @@ void Connector::CallOnHandleReady(void* closure, MojoResult result) {
}
void Connector::OnHandleReady(MojoResult result) {
- MOJO_DCHECK(async_wait_id_ != 0);
+ MOJO_CHECK(async_wait_id_ != 0);
async_wait_id_ = 0;
if (result != MOJO_RESULT_OK) {
NotifyError();
@@ -133,7 +133,7 @@ void Connector::OnHandleReady(MojoResult result) {
}
void Connector::WaitToReadMore() {
- MOJO_DCHECK(!async_wait_id_);
+ MOJO_CHECK(!async_wait_id_);
async_wait_id_ = waiter_->AsyncWait(message_pipe_.get().value(),
MOJO_HANDLE_SIGNAL_READABLE,
MOJO_DEADLINE_INDEFINITE,
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/lib/interface_impl_internal.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698